v16.12.0 proposal by richardlau · Pull Request #40504 · nodejs/node · GitHub

This is a quick release to clear the 50+ commits that are currently unreleased on v16.x-staging ahead of next week's LTS transition (where traditionally we only flip the LTS bit in those). Originally there was a planned regular 16 release for last week but that didn't happen because of the security releases that week.

This is intended to be the last "current" release of Node.js 16 and we'll expect future changes to 16 to be made under LTS guidelines.

2021-10-20, Version 16.12.0 (Current), @richardlau

Notable Changes

Experimental ESM Loader Hooks API

Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:

resolve: resolve [+ getFormat]
load: getFormat + getSource + transformSource

For consistency, getGlobalPreloadCode has been renamed to globalPreload.

A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.

Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468

Other Notable Changes

[8fdabcb918] - deps: upgrade npm to 8.1.0 (npm team) #40463
[d1d9f2de30] - doc: deprecate (doc-only) http abort related (dr-js) #36670
[4116b6c907] - (SEMVER-MINOR) vm: add support for import assertions in dynamic imports (Antoine du Hamel) #40249

Commits

[8bb3951e41] - build: remove duplicate check for authors.yml (Rich Trott) #40393
[2de57edced] - build: make scripts in gyp run with right python (Cheng Zhao) #39730
[a8926d199d] - crypto: remove incorrect constructor invocation (gc) #40300
[8fdabcb918] - deps: upgrade npm to 8.1.0 (npm team) #40463
[dca5ac1539] - deps: suppress zlib compiler warnings (Daniel Bevenius) #40343
[91c3bf6a7f] - deps: upgrade Corepack to 0.10 (Maël Nison) #40374
[7e02124a06] - dgram: add nread assertion to UDPWrap::OnRecv (Darshan Sen) #40295
[2d409ed29e] - dns: refactor and use validators (Voltrex) #40022
[dc7291dab8] - doc: remove ESLint comments which were breaking the CJS/ESM toggles (Mark Skelton) #40408
[85b7385115] - doc: add pronouns for tniessen to README (Tobias Nießen) #40412
[1d5857c9f4] - doc: format changelogs (Rich Trott) #40388
[5eb9402b50] - doc: fix missing variable in deepStrictEqual example (OliverOdo) #40396
[6f77d1a1d5] - doc: fix asyncLocalStorage.run() description (Constantine Kim) #40381
[93a48e02dc] - doc: fix typos in n-api docs (Ignacio Carbajo) #40402
[fb7afb91c2] - doc: format doc/guides using format-md task (Rich Trott) #40358
[6c091c7878] - doc: improve phrasing in fs.md (Arslan Ali) #40255
[38d81380ac] - doc: add link to core promises tracking issue (Michael Dawson) #40355
[71a94aa82a] - doc: correct ESM load hook table header (Jacob Smith) #40234
[5b074affb4] - doc: fix typo in esm.md (Mason Malone) #40273
[3b3aaa0a37] - doc: fix typo in ESM example (Tobias Nießen) #40275
[f848553fb8] - doc: assign missing deprecation number (Michaël Zasso) #40324
[d1d9f2de30] - doc: deprecate (doc-only) http abort related (dr-js) #36670
[1ef2cf8413] - doc: anchor link parity between markdown and html-generated docs (foxxyz) #39304
[3743406b0a] - (SEMVER-MINOR) esm: consolidate ESM loader hooks (Jacob Smith) #37468
[168020e1c8] - lib: refactor to use let (gdccwxx) #40364
[bcd59d70bb] - meta: consolidate AUTHORS entries for gabrielschulhof (Rich Trott) #40420
[80b4245db8] - meta: consolidate AUTHORS information for geirha (Rich Trott) #40406
[93cecb4700] - meta: consolidate duplicate AUTHORS entries for hassaanp (Rich Trott) #40391
[fff3135909] - meta: update AUTHORS (Node.js GitHub Bot) #40392
[122481713d] - meta: consolidate AUTHORS entry for thw0rted (Rich Trott) #40387
[7f50313fcc] - meta: update label-pr-config (Mestery) #40199
[5668182665] - meta: use .mailmap to consolidate AUTHORS entries for ide (Rich Trott) #40367
[bc86084a3e] - net: check if option is undefined (Daijiro Wachi) #40344
[4564a93e5e] - net: remove unused ObjectKeys (Daijiro Wachi) #40344
[dbb2e6f429] - net: check objectMode first and then readble || writable (Daijiro Wachi) #40344
[a672be57c8] - net: throw error to object mode in Socket (Daijiro Wachi) #40344
[faf9e28c36] - src: remove usage of AllocatedBuffer from stream_* (Darshan Sen) #40293
[857af2ba99] - src: add missing initialization (Michael Dawson) #40370
[2bfa87edbc] - stream: fix fromAsyncGen (Robert Nagy) #40499
[1e15137e71] - test: replace common port with specific number (Daijiro Wachi) #40344
[6f6b99c302] - test: fix typos in whatwg-webstreams explanations (Tobias Nießen) #40389
[641b1bb052] - test: add test for readStream.path when fd is specified (Qingyu Deng) #40359
[07dae7ff50] - test: replace .then chains with await (gdccwxx) #40348
[d8a36ee1de] - test: fix "test/common/debugger" identify async function (gdccwxx) #40348
[13d6a56c7d] - test: improve test coverage of fs.ReadStream with FileHandle (Antoine du Hamel) #40018
[50f91ab059] - tools: udpate @babel/eslint-parser (Rich Trott) #40394
[3611073145] - tools: remove @babel/plugin-syntax-import-assertions (Rich Trott) #40394
[b72d693a3a] - tools: remove @bable/plugin-syntax-class-properties (Rich Trott) #40394
[d6a99b77da] - tools: remove @babel/plugin-syntax-top-level-await (Rich Trott) #40394
[d9157aa5fe] - tools: update ESLint to 8.0.0 (Rich Trott) #40394
[43b97c7984] - tools: prepare ESLint rules for 8.0.0 requirements (Rich Trott) #40394
[282b6eb4b0] - tools: fix ESLint update scripts (Rich Trott) #40394
[c3a744f7bf] - tools: warn about duplicates when generating AUTHORS file (Rich Trott) #40304
[7733b5e55d] - typings: define types for os binding (Michaël Zasso) #40222
[ca9a854877] - typings: add missing types to options and util bindings (Michaël Zasso) #40222
[c3a7a0bd59] - typings: define types for timers binding (Michaël Zasso) #40222
[65b51d05fa] - typings: fix declaration of primordials (Michaël Zasso) #40222
[5f3f3a5128] - v8: remove --harmony-top-level-await (Geoffrey Booth) #40226
[4116b6c907] - (SEMVER-MINOR) vm: add support for import assertions in dynamic imports (Antoine du Hamel) #40249

Main changes: - Replace current HTML anchor generation to match header anchor generation in Github markdown. - Remove unnecessary double namespacing on generated anchors/links (E.G. `esm.md#loaders` instead of `esm.md#esm_loaders`). - Anchors/links are automatically prefixed with their respective modules when concatenated for usage in `all.html`. Benefits: - All anchor links within and between markdown API docs actually work. - Adding new anchor links no longer requires contributors to generate the HTML docs first to look up the correct anchors. - Anchors are much shorter. - All previous anchor links are preserved by generating hidden legacy anchors. PR-URL: #39304 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

doc: update ESM hook examples esm: fix unsafe primordial doc: fix ESM example linting esm: allow source of type ArrayBuffer doc: update ESM hook changelog to include resolve format esm: allow all ArrayBuffers and TypedArrays for load hook source doc: tidy code & API docs doc: convert ESM source table header from Title Case to Sentence case doc: add detailed explanation for getPackageType esm: add caveat that ESMLoader::import() must NOT be renamed esm: tidy code declaration of getFormat protocolHandlers doc: correct ESM doc link (bad conflict resolution) doc: update ESM hook limitation for CJS esm: tweak preload description doc: update ESM getPackageType() example explanation PR-URL: #37468 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

PR-URL: #40226 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #40300 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Refs: #36641 Refs: #36617 (comment) Documentation-only deprecate `.aborted` property and `'abort'`, `'aborted'` event in `http`, and suggest using the corresponding Stream API instead. Co-authored-by: Michaël Zasso <targos@protonmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: Robert Nagy <ronagy@icloud.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #36670 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Refs: #36670 PR-URL: #40324 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

Refs: #37468 PR-URL: #40275 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

_subpath_ is not defined in this context. This is pretty clearly meant to be _packageSubpath_, which is the second argument to `PACKAGE_SELF_RESOLVE` PR-URL: #40273 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

`resolve` does not return a `source` property PR-URL: #40234 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

The logical NOT operator and validators should be used where appropriate. PR-URL: #40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>

PR-URL: #40249 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40355 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

This asserts that the number of bytes received by the socket is less than or equal to the size allocated for the temporary storage. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40295 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

PR-URL: #40255 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #40304 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

James Ide has two AUTHORS entries. Use .mailmap to consolidate them into a single entry. PR-URL: #40367 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

PR-URL: #40358 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #40018 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

PR-URL: #40199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #40348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Refs: #40252 (review) PR-URL: #40359 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

move variable into each for loop PR-URL: #40364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Use a .mailmap entry to consolidate the two entries for thw0rted in AUTHORS into one entry. PR-URL: #40387 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #39730 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #40389 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #40222 Fixes: #40144 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: #40222 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

allowed returning format from either resolve or load hooks.

this is actually not correct: format MUST be returned by a load hook. So perhaps

allowed a returning format hint from resolve hook.

And, not sure if it matters: getGlobalPreloadCode was merely renamed to globalPreload (nothing else about it changed).

What would be really helpful is one or two sentences to go in the Notable changes section that explains why the change is notable for anyone reading the changelog. Otherwise we'll just have the following, which really doesn't suggest "This is a very notable change, as it changes how loader hooks work and deprecates the previous system." (maybe the sentence is "Changes the way loader hooks work and deprecates the previous system."?)

Notable Changes

[8fdabcb918] - deps: upgrade npm to 8.1.0 (npm team) #40463
[d1d9f2de30] - doc: deprecate (doc-only) http abort related (dr-js) #36670
[3743406b0a] - (SEMVER-MINOR) esm: consolidate ESM loader hooks (Jacob Smith) #37468
[4116b6c907] - (SEMVER-MINOR) vm: add support for import assertions in dynamic imports (Antoine du Hamel) #40249

these are coming from the author info in Git

gah, sorry. I dunno how that messed up on my laptop (I just fixed it in my git global config). I'll look into the mailmap this week.

I'll update the changelog here

thank you!

What would be really helpful is one or two sentences to go in the Notable changes section that explains why the change is notable for anyone reading the changelog.

okay! I shall send over this evening.

How about something like this:

Experimental ESM Loader Hooks API

Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining:

resolve: resolve [+ getFormat]
load: getFormat + getSource + transformSource

For consistency, getGlobalPreloadCode has been renamed to globalPreload.

A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks.

Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468

Ref: nodejs/node#40504

Notable Changes: Experimental ESM Loader Hooks API: Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining: 1. `resolve`: `resolve` [+ `getFormat`] 2. `load`: `getFormat` + `getSource` + `transformSource` For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`. A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks. Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468 Other Notable Changes: deps: * upgrade npm to 8.1.0 (npm team) #40463 doc: * deprecate (doc-only) http abort related (dr-js) #36670 vm: * (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249 PR-URL: #40504

I've updated the notable changes PTAL.

I've also bumped the date to tomorrow as it's late here.

CI: https://ci.nodejs.org/job/node-test-pull-request/40378/ (✔️)
Release build: https://ci-release.nodejs.org/job/iojs+release/8021/

PR-URL: #40504

Notable Changes: Experimental ESM Loader Hooks API: Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining: 1. `resolve`: `resolve` [+ `getFormat`] 2. `load`: `getFormat` + `getSource` + `transformSource` For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`. A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks. Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468 Other Notable Changes: deps: * upgrade npm to 8.1.0 (npm team) #40463 doc: * deprecate (doc-only) http abort related (dr-js) #36670 vm: * (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249 PR-URL: #40504

Refs: nodejs/node#40504

* update version checks for v16 Ref: nodejs/node#40504 * add test to check old ESM Loader Hooks API on v16.11.1 * fix wrong version number

foxxyz and others added 30 commits October 12, 2021 10:32

v8: remove --harmony-top-level-await

5f3f3a5

PR-URL: #40226 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

crypto: remove incorrect constructor invocation

a8926d1

PR-URL: #40300 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

doc: assign missing deprecation number

f848553

Refs: #36670 PR-URL: #40324 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

doc: correct ESM load hook table header

71a94aa

`resolve` does not return a `source` property PR-URL: #40234 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

dns: refactor and use validators

2d409ed

The logical NOT operator and validators should be used where appropriate. PR-URL: #40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>

vm: add support for import assertions in dynamic imports

4116b6c

PR-URL: #40249 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

doc: improve phrasing in fs.md

6c091c7

PR-URL: #40255 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

tools: warn about duplicates when generating AUTHORS file

c3a744f

PR-URL: #40304 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

doc: format doc/guides using format-md task

fb7afb9

PR-URL: #40358 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test: improve test coverage of fs.ReadStream with FileHandle

13d6a56

PR-URL: #40018 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

meta: update label-pr-config

7f50313

PR-URL: #40199 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

test: fix "test/common/debugger" identify async function

d8a36ee

PR-URL: #40348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

test: replace .then chains with await

07dae7f

PR-URL: #40348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

test: add test for readStream.path when fd is specified

641b1bb

Refs: #40252 (review) PR-URL: #40359 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

lib: refactor to use let

168020e

move variable into each for loop PR-URL: #40364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

test: fix typos in whatwg-webstreams explanations

6f6b99c

PR-URL: #40389 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

typings: define types for timers binding

c3a7a0b

PR-URL: #40222 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

typings: define types for os binding

7733b5e

PR-URL: #40222 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

shrujalshah28 added a commit to shrujalshah28/ts-node that referenced this pull request Oct 19, 2021

update version checks for v16

b53f1be

Ref: nodejs/node#40504

shrujalshah28 added a commit to shrujalshah28/ts-node that referenced this pull request Oct 19, 2021

update version checks for v16

bc5cdab

Ref: nodejs/node#40504

shrujalshah28 mentioned this pull request Oct 19, 2021

update version checks for v16 TypeStrong/ts-node#1522

Merged

richardlau force-pushed the v16.12.0-proposal branch from 4774eaf to 4941550 Compare October 19, 2021 21:13

This comment has been minimized.

Sign in to view

github-actions Bot mentioned this pull request Oct 20, 2021

CI Reliability 2021-10-20 nodejs/reliability#92

Open

27 tasks

danbev approved these changes Oct 20, 2021

View reviewed changes

BethGriggs approved these changes Oct 20, 2021

View reviewed changes

richardlau merged commit 4941550 into v16.x Oct 20, 2021

richardlau added a commit that referenced this pull request Oct 20, 2021

Working on v16.12.1

731495d

PR-URL: #40504

richardlau added a commit to nodejs/nodejs.org that referenced this pull request Oct 20, 2021

Blog: v16.12.0 release post

b16d6a5

Refs: nodejs/node#40504

richardlau mentioned this pull request Oct 20, 2021

Blog: v16.12.0 release post nodejs/nodejs.org#4199

Merged

richardlau added a commit to nodejs/nodejs.org that referenced this pull request Oct 20, 2021

Blog: v16.12.0 release post (#4199 )

880f472

Refs: nodejs/node#40504

richardlau deleted the v16.12.0-proposal branch October 20, 2021 15:13

github-actions Bot mentioned this pull request Oct 21, 2021

CI Reliability 2021-10-21 nodejs/reliability#93

Open

30 tasks

cspotcode pushed a commit to TypeStrong/ts-node that referenced this pull request Oct 21, 2021

update version checks for v16 (#1522 )

b16134b

* update version checks for v16 Ref: nodejs/node#40504 * add test to check old ESM Loader Hooks API on v16.11.1 * fix wrong version number

This was referenced Oct 22, 2021

CI Reliability 2021-10-22 nodejs/reliability#94

Open

CI Reliability 2021-10-23 nodejs/reliability#95

Open

CI Reliability 2021-10-24 nodejs/reliability#96

Open

CI Reliability 2021-10-25 nodejs/reliability#97

Open

RaisinTen mentioned this pull request Nov 18, 2021

async_hooks: unmerge resource_symbol from owner_symbol #40741

Closed

ruzell22 mentioned this pull request Mar 3, 2022

fix: custom-checks script from package.json does not work hyperledger-cacti/cacti#1809

Closed

v16.12.0 proposal by richardlau · Pull Request #40504 · nodejs/node · GitHub

Uh oh!

Uh oh!

v16.12.0 proposal - #40504

v16.12.0 proposal#40504
richardlau merged 60 commits into
v16.xfrom
v16.12.0-proposal

richardlau commented Oct 18, 2021 •
edited
Loading

Uh oh!

Uh oh!

richardlau commented Oct 19, 2021

Uh oh!

JakobJingleheimer commented Oct 19, 2021

Uh oh!

JakobJingleheimer commented Oct 19, 2021

Uh oh!

richardlau commented Oct 19, 2021 •
edited
Loading

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Oct 20, 2021 •
edited by richardlau
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v16.12.0 proposal by richardlau · Pull Request #40504 · nodejs/node · GitHub

Uh oh!

Uh oh!

v16.12.0 proposal - #40504

v16.12.0 proposal#40504richardlau merged 60 commits intov16.xnodejs/node:v16.xfrom v16.12.0-proposalnodejs/node:v16.12.0-proposalCopy head branch name to clipboard

Conversation

richardlau commented Oct 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2021-10-20, Version 16.12.0 (Current), @richardlau

Notable Changes

Experimental ESM Loader Hooks API

Other Notable Changes

Commits

Uh oh!

richardlau commented Oct 19, 2021

Notable Changes

Uh oh!

JakobJingleheimer commented Oct 19, 2021

Uh oh!

JakobJingleheimer commented Oct 19, 2021

Experimental ESM Loader Hooks API

Uh oh!

richardlau commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Oct 20, 2021 • edited by richardlau Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v16.12.0 proposal#40504
richardlau merged 60 commits into
v16.xfrom
v16.12.0-proposal

richardlau commented Oct 18, 2021 •
edited
Loading

richardlau commented Oct 19, 2021 •
edited
Loading

nodejs-github-bot commented Oct 20, 2021 •
edited by richardlau
Loading