test: fix "test/common/debugger" identify async function - #40348
Closed
gdccwxx wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
targos
reviewed
Oct 6, 2021
Comment thread
test/common/debugger.js
Outdated
jasnell
approved these changes
Oct 7, 2021
targos
approved these changes
Oct 8, 2021
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
21 tasks
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
PR-URL: #40348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
PR-URL: #40348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Oct 10, 2021
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
PR-URL: #40348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
PR-URL: #40348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
22 tasks
2 tasks
23 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: use async to identify function
waitForInitialBreak() return a promise function, should use async to identify it