src: remove usage of AllocatedBuffer from stream_* - #40293
Closed
RaisinTen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment has been minimized.
jasnell
approved these changes
Oct 3, 2021
addaleax
approved these changes
Oct 6, 2021
Comment thread
src/stream_base.cc
Outdated
Comment thread
src/stream_base.cc
Outdated
Comment thread
src/stream_base.cc
Outdated
Comment thread
src/stream_base.cc
Outdated
Comment thread
src/stream_base.cc
Outdated
Comment thread
src/stream_pipe.cc
Outdated
Comment thread
src/stream_base.cc
Outdated
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
src/remove-usage-of-AllocatedBuffer-from-stream
branch
from
d111e66 to
9ed6888
Compare
October 8, 2021 15:56
RaisinTen
commented
Oct 8, 2021
Comment thread
src/stream_base.cc
This comment has been minimized.
21 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Oct 10, 2021
addaleax
approved these changes
Oct 11, 2021
Copy link
Copy Markdown
Contributor
|
@RaisinTen The PR didn't land because the CI was running. I think you could remove the commit-queue label and put it back. pr 40293 skipped, CI still running https://github.com/nodejs/node/runs/3863311768?check_suite_focus=true#step:8:46 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I think we'll have to land this one manually. Sometimes GitHub's API reports pending checks that don't exist. |
Sorry, something went wrong.
RaisinTen
added a commit
that referenced
this pull request
Oct 12, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
22 tasks
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40293 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
22 tasks
2 tasks
This was referenced Oct 15, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen darshan.sen@postman.com