dns: refactor and use validators - #40022
Closed
VoltrexKeyva wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
VoltrexKeyva
force-pushed
the
patch-5
branch
3 times, most recently
from
44174a5 to
f9a76dd
Compare
September 6, 2021 23:23
jasnell
approved these changes
Sep 7, 2021
Ayase-252
approved these changes
Sep 15, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
18 tasks
The logical NOT operator and validators should be used where appropriate.
VoltrexKeyva
force-pushed
the
patch-5
branch
from
f9a76dd to
00d8ecb
Compare
September 16, 2021 20:27
Copy link
Copy Markdown
Contributor
Author
|
Merge conflict resolved. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
18 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
17 tasks
targos
pushed a commit
that referenced
this pull request
Sep 18, 2021
The logical NOT operator and validators should be used where appropriate. PR-URL: #40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
This was referenced Sep 19, 2021
This was referenced Sep 23, 2021
Copy link
Copy Markdown
Member
|
Needs a backport PR to land on v16.x. |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Oct 9, 2021
The logical NOT operator and validators should be used where appropriate. PR-URL: #40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Copy link
Copy Markdown
Member
|
Actually landed in 03c2432. The conflict was easy. |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Oct 12, 2021
The logical NOT operator and validators should be used where appropriate. PR-URL: #40022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logical NOT operator and validators should be used where appropriate.