FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: use .mailmap to consolidate AUTHORS entries for ide by Trott · Pull Request #40367 · nodejs/node · GitHub

/ node Public

meta: use .mailmap to consolidate AUTHORS entries for ide - #40367

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:mailmap-ji
Oct 9, 2021
ConversationCommits (1)ChecksFiles changed
Merged

meta: use .mailmap to consolidate AUTHORS entries for ide#40367
Trott merged 1 commit into
nodejs:masterfrom
Trott:mailmap-ji

Conversation

Trott commented Oct 7, 2021

Copy link
Copy Markdown
Member

James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
a single entry.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 7, 2021

Trott commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

@ide This removes your expo.io email from AUTHORS and leaves your jameside.com email there. (Currently both are in the file.) If you'd prefer it the other way around (leave expo.io and remove jameside.com) or a third email address to replace both entries, please leave a comment. Thanks!

ide commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

Could you please change the expo.io email to expo.dev? Thank you!

Trott commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

Could you please change the expo.io email to expo.dev? Thank you!

Ultimately, what's the one email address you want to show up in AUTHORS? Is it this?:

James Ide <ide@jameside.com>

Or this?:

James Ide <ide@expo.dev>

ide commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

Could you please use the jameside.com domain? Thank you!

Trott commented Oct 8, 2021

Copy link
Copy Markdown
Member Author

Could you please use the jameside.com domain? Thank you!

OK, cool, that's what this change does. (I can't change the expo.io to expo.dev because that's a .mailmap entry. If I change it, then it won't change your expo.io email in the git log to jameside.com and the expo.io entry will start showing up in AUTHORS again. What that entry says is "Wherever you see this expo.io email in the git log, treat it as this jameside.com email instead.")

Trott added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 8, 2021

github-actions Bot commented Oct 8, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

meta: use .mailmap to consolidate AUTHORS entries for ide
6a205d7 
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
a single entry.

PR-URL: nodejs#40367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

Trott commented Oct 9, 2021

Copy link
Copy Markdown
Member Author

Landed in 6a205d7

Trott merged commit 6a205d7 into nodejs:master Oct 9, 2021
Trott deleted the mailmap-ji branch October 9, 2021 15:08
targos pushed a commit that referenced this pull request Oct 13, 2021
meta: use .mailmap to consolidate AUTHORS entries for ide
5668182 
James Ide has two AUTHORS entries. Use .mailmap to consolidate them into
a single entry.

PR-URL: #40367
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
richardlau mentioned this pull request Oct 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
Lxxyx Lxxyx approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL