FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-domain-error-types flaky by jasnell · Pull Request #39369 · nodejs/node · GitHub

/ node Public

test: mark test-domain-error-types flaky - #39369

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:mark-test-domain-error-types-flaky
ConversationCommits (1)ChecksFiles changed
Closed

test: mark test-domain-error-types flaky#39369
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:mark-test-domain-error-types-flaky

Conversation

jasnell commented Jul 12, 2021

Copy link
Copy Markdown
Member

Refs: #39368
Signed-off-by: James M Snell jasnell@gmail.com

test: mark test-domain-error-types flaky
6e957b0 
Refs: nodejs#39368
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 12, 2021

github-actions Bot commented Jul 12, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 12, 2021

This comment has been minimized.

Sign in to view
jasnell mentioned this pull request Jul 12, 2021
Closed

nodejs-github-bot commented Jul 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39003/

jasnell requested review from mcollina and ronag July 12, 2021 22:37

jasnell commented Jul 13, 2021

Copy link
Copy Markdown
Member Author

Landed in 09b57f7

jasnell closed this Jul 13, 2021
jasnell added a commit that referenced this pull request Jul 13, 2021
test: mark test-domain-error-types flaky
09b57f7 
Refs: #39368
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #39369
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Jul 17, 2021
test: mark test-domain-error-types flaky
259d091 
Refs: #39368
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #39369
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs mentioned this pull request Jul 26, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
test: mark test-domain-error-types flaky
d8066f5 
Refs: #39368
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #39369
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos mentioned this pull request Sep 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gireeshpunathil gireeshpunathil approved these changes
mcollina Awaiting requested review from mcollina
ronag Awaiting requested review from ronag
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL