tools: add find-inactive-collaborators.js - #39262
Merged
Trott merged 1 commit intoJul 8, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
(And yes, I've emailed Thomas as well as a few others to see if they would be amenable to emeritus status at this time.) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This probably needs more robust error handling, but as a tool used internally in the project and not something end users ever run/see, we can also add that later. This also might be better incorporated into node-core-utils, but that means that the GitHub Action will have to install that every time. I could go either way on it. |
Sorry, something went wrong.
VoltrexKeyva
reviewed
Jul 5, 2021
Comment thread
tools/find-inactive-collaborators.js
Outdated
Trott
force-pushed
the
find-inactive-collaborators.js
branch
from
9367582 to
d9c85f4
Compare
July 5, 2021 01:49
aduh95
reviewed
Jul 5, 2021
Comment thread
tools/find-inactive-collaborators.js
Outdated
Comment thread
tools/find-inactive-collaborators.js
Outdated
aduh95
reviewed
Jul 5, 2021
Comment thread
tools/find-inactive-collaborators.js
Outdated
Trott
force-pushed
the
find-inactive-collaborators.js
branch
6 times, most recently
from
42fae35 to
912d361
Compare
July 5, 2021 23:28
aduh95
reviewed
Jul 6, 2021
Comment thread
tools/find-inactive-collaborators.mjs
Outdated
Trott
force-pushed
the
find-inactive-collaborators.js
branch
from
912d361 to
42241a8
Compare
July 7, 2021 04:21
jasnell
approved these changes
Jul 8, 2021
tniessen
approved these changes
Jul 8, 2021
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is this being checked by eslint? If not, maybe it should be.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Yes, if I remove a semicolon from the file, make lint-js reports it. |
Sorry, something went wrong.
The plan is to eventually call this script with a scheduled GitHub Action that could automatically open pull requests to move collaborators to emeritus status after (for example) a year of inactivity. Sample run: ``` $ node tools/find-inactive-collaborators.mjs '30 months ago' 864 authors have made commits since 30 months ago. 101 landers have landed commits since 30 months ago. 146 reviewers have approved landed commits since 30 months ago. 109 collaborators currently in the project. Inactive collaborators: Thomas Watson $ ``` PR-URL: nodejs#39262 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Trott
force-pushed
the
find-inactive-collaborators.js
branch
from
42241a8 to
5f3359d
Compare
July 8, 2021 13:57
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
The plan is to eventually call this script with a scheduled GitHub Action that could automatically open pull requests to move collaborators to emeritus status after (for example) a year of inactivity. Sample run: ``` $ node tools/find-inactive-collaborators.mjs '30 months ago' 864 authors have made commits since 30 months ago. 101 landers have landed commits since 30 months ago. 146 reviewers have approved landed commits since 30 months ago. 109 collaborators currently in the project. Inactive collaborators: Thomas Watson $ ``` PR-URL: #39262 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
The plan is to eventually call this script with a scheduled GitHub Action that could automatically open pull requests to move collaborators to emeritus status after (for example) a year of inactivity. Sample run: ``` $ node tools/find-inactive-collaborators.mjs '30 months ago' 864 authors have made commits since 30 months ago. 101 landers have landed commits since 30 months ago. 146 reviewers have approved landed commits since 30 months ago. 109 collaborators currently in the project. Inactive collaborators: Thomas Watson $ ``` PR-URL: #39262 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan is to eventually call this script with a scheduled GitHub
Action that could automatically open pull requests to move collaborators
to emeritus status after (for example) a year of inactivity.
Sample run: