FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify that fs.Dir async iterator closes automatically by jasnell · Pull Request #38438 · nodejs/node · GitHub

/ node Public

doc: clarify that fs.Dir async iterator closes automatically - #38438

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:fs-clarify-dir-async-iterator-close
ConversationCommits (2)ChecksFiles changed
Closed

doc: clarify that fs.Dir async iterator closes automatically#38438
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:fs-clarify-dir-async-iterator-close

Conversation

jasnell commented Apr 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #35148

github-actions Bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 27, 2021
jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 27, 2021

jasnell commented Apr 27, 2021

Copy link
Copy Markdown
Member Author

Simple change that shouldn't need to wait the 48 hours to land. Fast-track? Please 👍🏻

jasnell commented Apr 27, 2021

Copy link
Copy Markdown
Member Author

Landed in 87aca07

jasnell closed this Apr 27, 2021
jasnell added a commit that referenced this pull request Apr 27, 2021
doc: clarify that fs.Dir async iterator closes automatically
87aca07 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #35148

PR-URL: #38438
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 29, 2021
doc: clarify that fs.Dir async iterator closes automatically
1eae4af 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #35148

PR-URL: #38438
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
doc: clarify that fs.Dir async iterator closes automatically
7a92c3c 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #35148

PR-URL: #38438
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Sep 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc: undocumented magic: async iterator over fs.Dir will call dir.close() on iteration end

4 participants

Back | FazBrowse Home | New Git URL