FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: add .mailmap entry for new email for existing contributor by Trott · Pull Request #39431 · nodejs/node · GitHub

/ node Public

meta: add .mailmap entry for new email for existing contributor - #39431

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:update-ds
Closed

meta: add .mailmap entry for new email for existing contributor#39431
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:update-ds

Conversation

Trott commented Jul 18, 2021

Copy link
Copy Markdown
Member

No description provided.

Trott requested a review from RaisinTen July 18, 2021 23:46
nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 18, 2021

Trott commented Jul 18, 2021

Copy link
Copy Markdown
Member Author

@RaisinTen Not sure if you want to map the new email to the old one, like I did here, or if you'd rather do it the other way around and have the old email address map to the new one?

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 19, 2021
Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 19, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

jasnell commented Jul 19, 2021

Copy link
Copy Markdown
Member

Landed in d0b440c

jasnell closed this Jul 19, 2021
jasnell pushed a commit that referenced this pull request Jul 19, 2021
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2021
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs mentioned this pull request Jul 26, 2021
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott deleted the update-ds branch September 25, 2022 17:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL