FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update path-parse in markdown linter package-lock file by Trott · Pull Request #39729 · nodejs/node · GitHub

/ node Public

tools: update path-parse in markdown linter package-lock file - #39729

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:path-parse
ConversationCommits (1)ChecksFiles changed
Closed

tools: update path-parse in markdown linter package-lock file#39729
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:path-parse

Conversation

Trott commented Aug 10, 2021

Copy link
Copy Markdown
Member

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 10, 2021

github-actions Bot commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 10, 2021
Trott changed the title tools: update path-parse in markdown linter tools: update path-parse in markdown linter package-lock file Aug 11, 2021

Trott commented Aug 11, 2021

Copy link
Copy Markdown
Member Author

This changes the package-lock.json but not the resulting lint-md.js file because path-parse is in a devDependency and the update does not affect the output of the build script.

Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Aug 13, 2021

Trott commented Aug 13, 2021

Copy link
Copy Markdown
Member Author

48 hours has passed so this no longer needs a fast-track, but it could use a second review/approval..... @nodejs/linting

targos commented Aug 13, 2021

Copy link
Copy Markdown
Member

What is changed in lint-md.js? The mobile UI just shows -0 +0

nschonni commented Aug 13, 2021

Copy link
Copy Markdown
Member

The execute bit was set. It's now 755

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2021

github-actions Bot commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

Landed in ae0cfc9...1150cfe

github-actions Bot closed this Aug 13, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 13, 2021
tools: update path-parse in markdown linter package-lock file
1150cfe 
Refs: GHSA-hj48-42vr-x3v9

PR-URL: #39729
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
tools: update path-parse in markdown linter package-lock file
eb74125 
Refs: GHSA-hj48-42vr-x3v9

PR-URL: #39729
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams mentioned this pull request Aug 16, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
tools: update path-parse in markdown linter package-lock file
f8fee44 
Refs: GHSA-hj48-42vr-x3v9

PR-URL: #39729
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos mentioned this pull request Sep 4, 2021
Merged
Trott deleted the path-parse branch September 25, 2022 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
+2 more reviewers
nschonni nschonni approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL