FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: add mailmap entries for ttzztztz and garygsc by Trott · Pull Request #39588 · nodejs/node · GitHub

/ node Public

meta: add mailmap entries for ttzztztz and garygsc - #39588

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:mailmap-again
Closed

meta: add mailmap entries for ttzztztz and garygsc#39588
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:mailmap-again

Conversation

Trott commented Jul 30, 2021

Copy link
Copy Markdown
Member

Add mailmap entries and re-run AUTHORS to remove duplicates.

@ttzztztz @GaryGSC If I haven't used the email addresses that you prefer for the AUTHORS file, please leave a comment. Thanks! (For garygsc, it's the gmail address, and for ttzztztz, it's the outlook address.)

Trott added 2 commits July 30, 2021 03:17
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.
nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 30, 2021

ttzztztz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jul 30, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

GaryGSC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks!

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2021

Copy link
Copy Markdown
Contributor

Landed in b4ae702...46e6c64

github-actions Bot closed this Jul 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 30, 2021
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 30, 2021
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.

PR-URL: #39588
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott deleted the mailmap-again branch September 25, 2022 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL