FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: check mustCall errors in test-fs-read-type by tniessen · Pull Request #36914 · nodejs/node · GitHub

/ node Public

test: check mustCall errors in test-fs-read-type - #36914

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:test-make-checks-stricter-in-fs-read-type
ConversationCommits (1)ChecksFiles changed
Closed

test: check mustCall errors in test-fs-read-type#36914
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:test-make-checks-stricter-in-fs-read-type

Conversation

tniessen commented Jan 13, 2021

Copy link
Copy Markdown
Member

The async tests, which are modified in this PR, appear to be the async equivalents of these synchronous tests:

node/test/parallel/test-fs-read-type.js

Lines 222 to 239 in 251a0ff

fs.readSync(fd,
Buffer.allocUnsafe(expected.length),
0,
expected.length,
0n);
try {
fs.readSync(fd,
Buffer.allocUnsafe(expected.length),
0,
expected.length,
2n ** 53n - 1n);
} catch (err) {
// On systems where max file size is below 2^53-1, we'd expect a EFBIG error.
// This is not using `assert.throws` because the above call should not raise
// any error on systems that allows file of that size.
if (err.code !== 'EFBIG') throw err;
}

The async tests did not check for errors properly.

Refs: #36190

nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 13, 2021

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35525/

tniessen added the fs Issues and PRs related to the fs subsystem / file system. label Jan 13, 2021

nodejs-github-bot commented Jan 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35532/

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 13, 2021
tniessen added a commit that referenced this pull request Jan 15, 2021
test: check mustCall errors in test-fs-read-type
d7b1866 
PR-URL: #36914
Refs: #36190
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

tniessen commented Jan 15, 2021

Copy link
Copy Markdown
Member Author

Landed in d7b1866, thanks for reviewing.

tniessen closed this Jan 15, 2021
tniessen deleted the test-make-checks-stricter-in-fs-read-type branch January 15, 2021 17:13
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
test: check mustCall errors in test-fs-read-type
c2ec15a 
PR-URL: #36914
Refs: #36190
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno mentioned this pull request Jan 22, 2021
Merged
tniessen removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 23, 2021
targos pushed a commit that referenced this pull request Aug 8, 2021
test: check mustCall errors in test-fs-read-type
3b25cbe 
PR-URL: #36914
Refs: #36190
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
test: check mustCall errors in test-fs-read-type
e4c9b45 
PR-URL: #36914
Refs: #36190
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 31, 2021
test: check mustCall errors in test-fs-read-type
f3be3ec 
PR-URL: #36914
Refs: #36190
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Sep 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL