FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: pass bot token to node-pr-labeler by targos · Pull Request #39271 · nodejs/node · GitHub

/ node Public

tools: pass bot token to node-pr-labeler - #39271

Closed
targos wants to merge 1 commit into
masterfrom
targos-patch-1
Closed

tools: pass bot token to node-pr-labeler#39271
targos wants to merge 1 commit into
masterfrom
targos-patch-1

Conversation

targos commented Jul 5, 2021

Copy link
Copy Markdown
Member

This should allow workflows that use the labeled event to be run.

Currently, fast-track requests for npm updates do not result in a comment: #39225 (comment)

This should allow workflows that use the `labeled` event to be run.
github-actions Bot added the meta Issues and PRs related to the general management of the project. label Jul 5, 2021

targos commented Jul 7, 2021

Copy link
Copy Markdown
Member Author

@nodejs/actions

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2021

github-actions Bot commented Jul 9, 2021

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/39271
✔  Done loading data for nodejs/node/pull/39271
----------------------------------- PR info ------------------------------------
Title      tools: pass bot token to node-pr-labeler (#39271)
Author     Michaël Zasso  (@targos)
Branch     targos:targos-patch-1 -> nodejs:master
Labels     meta
Commits    1
 - tools: pass bot token to node-pr-labeler
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/39271
Reviewed-By: James M Snell 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39271
Reviewed-By: James M Snell 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 05 Jul 2021 13:50:27 GMT
   ✔  Approvals: 3
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39271#pullrequestreview-701555483
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/39271#pullrequestreview-701570794
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39271#pullrequestreview-702952670
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1015485730

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 9, 2021

targos commented Jul 9, 2021

Copy link
Copy Markdown
Member Author

GitHub CI is still running?

targos commented Jul 9, 2021

Copy link
Copy Markdown
Member Author

I assume it's a bug with GitHub. The API reports a check that is queued, but it doesn't exist...

targos commented Jul 9, 2021

Copy link
Copy Markdown
Member Author

Landed in e4462bd

targos closed this Jul 9, 2021
targos added a commit that referenced this pull request Jul 9, 2021
This should allow workflows that use the `labeled` event to be run.

PR-URL: #39271
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos deleted the targos-patch-1 branch July 9, 2021 15:03
targos added a commit that referenced this pull request Jul 11, 2021
This should allow workflows that use the `labeled` event to be run.

PR-URL: #39271
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos added a commit that referenced this pull request Sep 4, 2021
This should allow workflows that use the `labeled` event to be run.

PR-URL: #39271
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL