FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc,meta: update email addresses for misterdjules by Trott · Pull Request #39433 · nodejs/node · GitHub

/ node Public

doc,meta: update email addresses for misterdjules - #39433

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:mdj
Jul 21, 2021
Merged

doc,meta: update email addresses for misterdjules#39433
Trott merged 1 commit into
nodejs:masterfrom
Trott:mdj

Conversation

Trott commented Jul 19, 2021

Copy link
Copy Markdown
Member

Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
update-authors.js so they only have one entry in AUTHORS.

Trott requested a review from misterdjules July 19, 2021 04:46
nodejs-github-bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Jul 19, 2021
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
`update-authors.js` so they only have one entry in AUTHORS.

PR-URL: nodejs#39433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott commented Jul 21, 2021

Copy link
Copy Markdown
Member Author

Landed in 5100c3c

Trott merged commit 5100c3c into nodejs:master Jul 21, 2021
Trott deleted the mdj branch July 21, 2021 05:02
targos pushed a commit that referenced this pull request Jul 21, 2021
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
`update-authors.js` so they only have one entry in AUTHORS.

PR-URL: #39433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request Jul 26, 2021

Copy link
Copy Markdown

Thank you @Trott, and sorry I didn't notice this PR until now.

BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
`update-authors.js` so they only have one entry in AUTHORS.

PR-URL: #39433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Julien Gilli appears twice with two email addresses in the current
AUTHORS file. Use .mailmap to map one to the other (keeping the most
recent one). Also update email in the README from a (I believe invalid,
since it is not listed in the email repo aliases.json file) nodejs.org
email to the email they more recently committed with. Finally, re-run
`update-authors.js` so they only have one entry in AUTHORS.

PR-URL: #39433
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL