tools: update markdown lint dependencies - #39770
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
rollup and remark/unified-args stop playing nicely with each other if they are brought entirely up to date, but this brings them as far as they can go without problems. (Maybe a bugfix release in one of the packages will fix everything and we can update fully. Or we can go with #39760 and remove rollup.) This also removes an unnecessary dependency (remark-lint). We're using a preset, and presets already include remark-lint itself. We'd only need remark-lint if we were using only plugins and no preset. |
Sorry, something went wrong.
tniessen
approved these changes
Aug 15, 2021
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
jasnell
approved these changes
Aug 15, 2021
aduh95
approved these changes
Aug 16, 2021
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 17, 2021
PR-URL: #39770 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 22, 2021
PR-URL: #39770 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #39770 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.