FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove eslint-disable comment from fixture file by Trott · Pull Request #39320 · nodejs/node · GitHub

/ node Public

test: remove eslint-disable comment from fixture file - #39320

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:no-lint-fixtures
Jul 11, 2021
Merged

test: remove eslint-disable comment from fixture file#39320
Trott merged 1 commit into
nodejs:masterfrom
Trott:no-lint-fixtures

Conversation

Trott commented Jul 9, 2021

Copy link
Copy Markdown
Member

Fixtures are not linted so eslint-disable comments are unnecessary.

github-actions Bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 9, 2021
Trott force-pushed the no-lint-fixtures branch from a052efb to 38d29a4 Compare July 9, 2021 04:52
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2021

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 10, 2021
Fixtures are not linted so eslint-disable comments are unnecessary.

PR-URL: nodejs#39320
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Trott force-pushed the no-lint-fixtures branch from 38d29a4 to 8970fa9 Compare July 11, 2021 04:53

Trott commented Jul 11, 2021

Copy link
Copy Markdown
Member Author

Landed in 8970fa9

Trott merged commit 8970fa9 into nodejs:master Jul 11, 2021
Trott deleted the no-lint-fixtures branch July 11, 2021 04:53
targos pushed a commit that referenced this pull request Jul 11, 2021
Fixtures are not linted so eslint-disable comments are unnecessary.

PR-URL: #39320
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Fixtures are not linted so eslint-disable comments are unnecessary.

PR-URL: #39320
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL