FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: update AUTHORS by Trott · Pull Request #39636 · nodejs/node · GitHub

/ node Public

meta: update AUTHORS - #39636

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:u-a
ConversationCommits (1)ChecksFiles changed
Closed

meta: update AUTHORS#39636
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:u-a

Conversation

Trott commented Aug 2, 2021

Copy link
Copy Markdown
Member

No description provided.

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 2, 2021
nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 2, 2021

github-actions Bot commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

tniessen commented Aug 3, 2021

Copy link
Copy Markdown
Member

Did I miss something that led to the multitude of these PRs? Can't we automate this if it really is necessary to keep the list up-to-date?

Trott commented Aug 3, 2021

Copy link
Copy Markdown
Member Author

Did I miss something that led to the multitude of these PRs? Can't we automate this if it really is necessary to keep the list up-to-date?

Batching the updates results in easy-to-miss errors/duplicate entries. But that's not a big enough problem that it warrants a process that annoys maintainers. So I could stop doing these so frequently. Or we could land @bnb's automation for this and iterate on that: #35831

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2021

github-actions Bot commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

Landed in 79b2c9a...fe3c5a7

github-actions Bot closed this Aug 4, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 4, 2021
meta: update AUTHORS
fe3c5a7 
PR-URL: #39636
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
meta: update AUTHORS
f413a9d 
PR-URL: #39636
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
danielleadams mentioned this pull request Aug 16, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
meta: update AUTHORS
3e8fc49 
PR-URL: #39636
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos mentioned this pull request Sep 4, 2021
Merged
Trott deleted the u-a branch September 25, 2022 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
tniessen tniessen approved these changes
+1 more reviewer
antsmartian antsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL