FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: convert anonymous function to arrow function by himadriganguly · Pull Request #39604 · nodejs/node · GitHub

/ node Public

test: convert anonymous function to arrow function - #39604

Closed
himadriganguly wants to merge 1 commit into
nodejs:masterfrom
himadriganguly:function-to-arrow
ConversationCommits (1)ChecksFiles changed
Closed

test: convert anonymous function to arrow function#39604
himadriganguly wants to merge 1 commit into
nodejs:masterfrom
himadriganguly:function-to-arrow

Conversation

himadriganguly commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

This commit converts the anonymous function to the arrow function in the file test/parallel/test-http-write-head-2.js.

Checklist

  • make -j4 test (UNIX) or vcbuild test (Windows) passes
  • commit message follow commit guidelines

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 31, 2021
himadriganguly changed the title code: convert anonymous function to arrow function test: convert anonymous function to arrow function Jul 31, 2021
gireeshpunathil added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2021

nodejs-github-bot commented Jul 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39376/

himadriganguly commented Jul 31, 2021

Copy link
Copy Markdown
Contributor Author

Can anyone please guide me on why the test is failing so that I can fix it. Thank you all in advance. @gireeshpunathil @tniessen

nodejs-github-bot commented Jul 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39381/

tniessen commented Jul 31, 2021

Copy link
Copy Markdown
Member

@himadriganguly The failure appears to be unrelated to your changes. I have restarted the failing tasks. Thank you for your contribution :)

himadriganguly commented Jul 31, 2021

Copy link
Copy Markdown
Contributor Author

@himadriganguly The failure appears to be unrelated to your changes. I have restarted the failing tasks. Thank you for your contribution :)

Thank you @tniessen. 👍

nodejs-github-bot commented Jul 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39382/

nodejs-github-bot commented Jul 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39383/

tniessen commented Jul 31, 2021

Copy link
Copy Markdown
Member

aix72-ppc64 appears to be having issues, cc @nodejs/build

Trott commented Jul 31, 2021

Copy link
Copy Markdown
Member

aix72-ppc64 appears to be having issues, cc @nodejs/build

The IBM folks will need to take a look at that and probably won't get to it until Monday. However, there is at least one other AIX host, so I marked that one as offline.

nodejs-github-bot commented Jul 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39386/

Trott mentioned this pull request Jul 31, 2021
Closed
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 2, 2021

github-actions Bot commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

Landed in ac621ff...fcc3910

github-actions Bot closed this Aug 2, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 2, 2021
test: convert anonymous function to arrow function
fcc3910 
PR-URL: #39604
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
himadriganguly deleted the function-to-arrow branch August 2, 2021 13:37
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
test: convert anonymous function to arrow function
1962c7c 
PR-URL: #39604
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams mentioned this pull request Aug 16, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
test: convert anonymous function to arrow function
68ef265 
PR-URL: #39604
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos mentioned this pull request Sep 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
gireeshpunathil gireeshpunathil approved these changes
Lxxyx Lxxyx approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL