tools,test: apply consistent comma-dangle lint rule - #37930
Merged
Trott merged 2 commits intoApr 2, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Mar 27, 2021
DerekNonGeneric
approved these changes
Apr 1, 2021
Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: nodejs#37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Use comma-dangle settings from the rest of the code base on tests as well. PR-URL: nodejs#37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Copy link
Copy Markdown
Contributor
|
Do we want this on v15.x? If so it will need a backport |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Backport in #38089 |
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 5, 2021
Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: nodejs#37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 5, 2021
Use comma-dangle settings from the rest of the code base on tests as well. PR-URL: nodejs#37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: #37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Use comma-dangle settings from the rest of the code base on tests as well. PR-URL: #37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use comma-dangle settings from the rest of the code base on tests as well.