[v15.x backport]: tools,test: apply consistent comma-dangle lint rule - #38089
Closed
Trott wants to merge 2 commits into
Closed
[v15.x backport]: tools,test: apply consistent comma-dangle lint rule #38089Trott wants to merge 2 commits into
Trott wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
marsonya
approved these changes
Apr 5, 2021
MylesBorins
force-pushed
the
v15.x-staging
branch
from
7a4cb16 to
629e72e
Compare
April 5, 2021 16:57
Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: nodejs#37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Use comma-dangle settings from the rest of the code base on tests as well. PR-URL: nodejs#37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Copy link
Copy Markdown
Member
Author
|
Looks like that path.posix.relative() change was removed from 15.x.-staging, so I rebased this to show the correct commits in the diff. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
15.x is now EOL. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport for #37930