test: use template to concatenate string - #39621
Closed
himadriganguly wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gireeshpunathil
approved these changes
Aug 2, 2021
aduh95
approved these changes
Aug 2, 2021
Copy link
Copy Markdown
Member
|
Nit in commit message: test: use ... instead of test: using ... |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
@targos Thank you for the feedback. I will do it right now. |
Sorry, something went wrong.
himadriganguly
force-pushed
the
template-string
branch
from
c33b06a to
4b83c63
Compare
August 2, 2021 08:51
himadriganguly
force-pushed
the
template-string
branch
from
4b83c63 to
b515bca
Compare
August 2, 2021 08:52
tniessen
approved these changes
Aug 2, 2021
lpinca
approved these changes
Aug 2, 2021
benjamingr
approved these changes
Aug 3, 2021
jasnell
approved these changes
Aug 3, 2021
Copy link
Copy Markdown
Contributor
Author
|
Is there any issue with the merge? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
no, just that someone needs to take it forward, I will take some actions. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 6, 2021
PR-URL: #39621 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39621 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #39621 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit converts the variable to be embedded within string literals using template string in the file test/parallel/test-trace-events-fs-sync.js.
Checklist
I used ./node test/parallel/test-trace-events-fs-sync.js as well, and it run without errors.