Commit 83e02dc
build: compile bundled ada conditionally
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.
Resolves #52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent f9d25ed commit 83e02dc
2 files changed
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -851,7 +851,6 @@ | |||
| 851 | 851 | 'deps/histogram/histogram.gyp:histogram', | |
| 852 | 852 | 'deps/simdjson/simdjson.gyp:simdjson', | |
| 853 | 853 | 'deps/simdutf/simdutf.gyp:simdutf', | |
| 854 | - 'deps/ada/ada.gyp:ada', | ||
| 855 | 854 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 856 | 855 | 'node_js2c#host', | |
| 857 | 856 | ], | |
@@ -1126,7 +1125,6 @@ | |||
| 1126 | 1125 | 'deps/googletest/googletest.gyp:gtest_prod', | |
| 1127 | 1126 | 'deps/histogram/histogram.gyp:histogram', | |
| 1128 | 1127 | 'deps/uvwasi/uvwasi.gyp:uvwasi', | |
| 1129 | - 'deps/ada/ada.gyp:ada', | ||
| 1130 | 1128 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1131 | 1129 | ], | |
| 1132 | 1130 | 'includes': [ | |
@@ -1175,7 +1173,6 @@ | |||
| 1175 | 1173 | 'deps/histogram/histogram.gyp:histogram', | |
| 1176 | 1174 | 'deps/simdjson/simdjson.gyp:simdjson', | |
| 1177 | 1175 | 'deps/simdutf/simdutf.gyp:simdutf', | |
| 1178 | - 'deps/ada/ada.gyp:ada', | ||
| 1179 | 1176 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1180 | 1177 | ], | |
| 1181 | 1178 | ||
@@ -1253,7 +1250,6 @@ | |||
| 1253 | 1250 | 'dependencies': [ | |
| 1254 | 1251 | '<(node_lib_target_name)', | |
| 1255 | 1252 | 'deps/histogram/histogram.gyp:histogram', | |
| 1256 | - 'deps/ada/ada.gyp:ada', | ||
| 1257 | 1253 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1258 | 1254 | ], | |
| 1259 | 1255 | ||
@@ -1367,7 +1363,6 @@ | |||
| 1367 | 1363 | 'dependencies': [ | |
| 1368 | 1364 | '<(node_lib_target_name)', | |
| 1369 | 1365 | 'deps/histogram/histogram.gyp:histogram', | |
| 1370 | - 'deps/ada/ada.gyp:ada', | ||
| 1371 | 1366 | 'deps/nbytes/nbytes.gyp:nbytes', | |
| 1372 | 1367 | 'deps/simdjson/simdjson.gyp:simdjson', | |
| 1373 | 1368 | 'deps/simdutf/simdutf.gyp:simdutf', | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -212,6 +212,10 @@ | |||
| 212 | 212 | 'dependencies': [ 'deps/nghttp2/nghttp2.gyp:nghttp2' ], | |
| 213 | 213 | }], | |
| 214 | 214 | ||
| 215 | + [ 'node_shared_ada=="false"', { | ||
| 216 | + 'dependencies': [ 'deps/ada/ada.gyp:ada' ], | ||
| 217 | + }], | ||
| 218 | + | ||
| 215 | 219 | [ 'node_shared_brotli=="false"', { | |
| 216 | 220 | 'dependencies': [ 'deps/brotli/brotli.gyp:brotli' ], | |
| 217 | 221 | }], | |
0 commit comments