util: assert getCallSites does not invoke Error.prepareStackTrace · nodejs/node@862eaf8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 862eaf8

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

RafaelGSS

committed

util: assert getCallSites does not invoke Error.prepareStackTrace

PR-URL: #60922 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

1 parent b4bad20 commit 862eaf8
Copy full SHA for 862eaf8

2 files changed

+17Lines changed: 17 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • util.md
• test/parallel
  • test-util-getcallsites-preparestacktrace.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/util.md‎

Copy file name to clipboardExpand all lines: doc/api/util.md

+3Lines changed: 3 additions & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -564,6 +564,9 @@ changes:
564	564	Returns an array of call site objects containing the stack of
565	565	the caller function.
566	566
	567	+ Unlike accessing an `error.stack`, the result returned from this API is not
	568	+ interfered with `Error.prepareStackTrace`.
	569	+
567	570	```mjs
568	571	import { getCallSites } from 'node:util';
569	572

Collapse file

‎test/parallel/test-util-getcallsites-preparestacktrace.js‎

Copy file name to clipboard

+14Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,14 @@
	1	+ 'use strict';
	2	+
	3	+ const common = require('../common');
	4	+ const assert = require('node:assert');
	5	+ const { getCallSites } = require('node:util');
	6	+
	7	+ // Asserts that util.getCallSites() does not invoke
	8	+ // Error.prepareStackTrace.
	9	+
	10	+ Error.prepareStackTrace = common.mustNotCall();
	11	+
	12	+ const sites = getCallSites(1);
	13	+ assert.strictEqual(sites.length, 1);
	14	+ assert.strictEqual(sites[0].scriptName, __filename);

0 commit comments

Comments

0 (0)