FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: assert getCallSites does not invoke Error.prepareStackTrace by legendecas · Pull Request #60922 · nodejs/node · GitHub

/ node Public

util: assert getCallSites does not invoke Error.prepareStackTrace - #60922

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:get-callsite
Dec 3, 2025
Merged

util: assert getCallSites does not invoke Error.prepareStackTrace#60922
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:get-callsite

Conversation

Copy link
Copy Markdown
Member

Assert that util.getCallSites does not invoke Error.prepareStackTrace.

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 1, 2025

codecov Bot commented Dec 1, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.50%. Comparing base (f9f343f) to head (b01bdf9).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60922      +/-   ##
==========================================
- Coverage   88.51%   88.50%   -0.01%     
==========================================
  Files         703      703              
  Lines      208394   208394              
  Branches    40189    40187       -2     
==========================================
- Hits       184450   184449       -1     
- Misses      15930    15967      +37     
+ Partials     8014     7978      -36     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas added util Issues and PRs related to the built-in util module. request-ci Add this label to start a Jenkins CI on a PR. doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Dec 2, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2025

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

legendecas added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 3, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 3, 2025
nodejs-github-bot merged commit 746c3c2 into nodejs:main Dec 3, 2025
91 of 92 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 746c3c2

legendecas deleted the get-callsite branch December 4, 2025 10:41
targos pushed a commit that referenced this pull request Dec 5, 2025
PR-URL: #60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
PR-URL: #60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
PR-URL: #60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 19, 2026
PR-URL: #60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
PR-URL: #60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 19, 2026
PR-URL: #60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 21, 2026
PR-URL: #60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
aduh95 mentioned this pull request Feb 22, 2026
aduh95 pushed a commit that referenced this pull request Feb 23, 2026
PR-URL: #60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL