test: make sure vtable is generated in addon test with LTO · nodejs/node@87e977a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 87e977a

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

BridgeAR

committed

test: make sure vtable is generated in addon test with LTO

PR-URL: #28057 Fixes: #28026 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

1 parent 3feaf3d commit 87e977a
Copy full SHA for 87e977a

1 file changed

+8-1Lines changed: 8 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/addons/uv-handle-leak
  • binding.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/addons/uv-handle-leak/binding.cc‎

Copy file name to clipboardExpand all lines: test/addons/uv-handle-leak/binding.cc

+8-1Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -15,9 +15,16 @@ void CloseCallback(uv_handle_t* handle) {}
15	15
16	16	class ExampleOwnerClass {
17	17	public:
18		- virtual ~ExampleOwnerClass() {}
	18	+ virtual ~ExampleOwnerClass();
19	19	};
20	20
	21	+ // Do not inline this into the class, because that may remove the virtual
	22	+ // table when LTO is used, and with it the symbol for which we grep the process
	23	+ // output in test/abort/test-addon-uv-handle-leak.
	24	+ // When the destructor is not inlined, the compiler will have to assume that it,
	25	+ // and the vtable, is part of what this compilation unit exports, and keep them.
	26	+ ExampleOwnerClass::~ExampleOwnerClass() {}
	27	+
21	28	ExampleOwnerClass example_instance;
22	29
23	30	void LeakHandle(const FunctionCallbackInfo<Value>& args) {

0 commit comments

Comments

0 (0)