FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: make sure vtable is generated in addon test with LTO by addaleax · Pull Request #28057 · nodejs/node · GitHub

/ node Public

test: make sure vtable is generated in addon test with LTO - #28057

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:test-vtable
ConversationCommits (1)ChecksFiles changed
Closed

test: make sure vtable is generated in addon test with LTO#28057
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:test-vtable

Conversation

addaleax commented Jun 4, 2019

Copy link
Copy Markdown
Member

Fixes: #28026

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

addaleax mentioned this pull request Jun 4, 2019
Closed
4 tasks
addaleax added addons Issues and PRs related to native addons. c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests. labels Jun 4, 2019

nodejs-github-bot commented Jun 4, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23614/

nodejs-github-bot commented Jun 4, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23619/

richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 4, 2019

danbev commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

Landed in b31bfad.

danbev closed this Jun 7, 2019
danbev pushed a commit that referenced this pull request Jun 7, 2019
test: make sure vtable is generated in addon test with LTO
b31bfad 
PR-URL: #28057
Fixes: #28026
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
test: make sure vtable is generated in addon test with LTO
87e977a 
PR-URL: #28057
Fixes: #28026
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR mentioned this pull request Jun 17, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: abort/test-addon-uv-handle-leak failure when LTO is enabled

5 participants

Back | FazBrowse Home | New Git URL