Commit 9024436
crypto: fix KeyObject garbage collection
These objects don’t hold any resources on the event loop, so they
should be weak objects that can be garbage collected when nothing
refers to them anymore.
PR-URL: #35481
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 1cd1d01 commit 9024436
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -518,7 +518,9 @@ class NativeKeyObject : public BaseObject { | |||
| 518 | 518 | v8::Local<v8::Object> wrap, | |
| 519 | 519 | const std::shared_ptr<KeyObjectData>& handle_data) | |
| 520 | 520 | : BaseObject(env, wrap), | |
| 521 | - handle_data_(handle_data) {} | ||
| 521 | + handle_data_(handle_data) { | ||
| 522 | + MakeWeak(); | ||
| 523 | + } | ||
| 522 | 524 | ||
| 523 | 525 | std::shared_ptr<KeyObjectData> handle_data_; | |
| 524 | 526 | }; | |
0 commit comments