test: use reserved .invalid TLD for invalid address in test · nodejs/node@902c670 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 902c670

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

MylesBorins

committed

test: use reserved .invalid TLD for invalid address in test

RFC 2606 reserves ithe .invalid top-level-domain for use in "domain names that are sure to be invalid and which it is obvious at a glance are invalid." Replace `dne.example.com` which actually isn't guaranteed to not exist. (example.com is for examples, but at least one address does in fact exist in that TLD.) PR-URL: #30545 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 92f766b commit 902c670
Copy full SHA for 902c670

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/internet
  • test-dgram-send-cb-quelches-error.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/internet/test-dgram-send-cb-quelches-error.js‎

Copy file name to clipboardExpand all lines: test/internet/test-dgram-send-cb-quelches-error.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -24,7 +24,7 @@ function callbackOnly(err) {
24	24	assert.ok(err);
25	25	socket.removeListener('error', onEvent);
26	26	socket.on('error', mustCall(onError));
27		- socket.send(buffer, 0, buffer.length, 100, 'dne.example.com');
	27	+ socket.send(buffer, 0, buffer.length, 100, 'dne.invalid');
28	28	}
29	29
30	30	function onEvent(err) {

0 commit comments

Comments

0 (0)