FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve test-dgram-send-cb-quelches-error by Trott · Pull Request #30545 · nodejs/node · GitHub

/ node Public

test: improve test-dgram-send-cb-quelches-error - #30545

Closed
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:quelch
ConversationCommits (0)ChecksFiles changed
Closed

test: improve test-dgram-send-cb-quelches-error#30545
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:quelch

Conversation

Trott commented Nov 19, 2019

Copy link
Copy Markdown
Member
  • When an error occurs unexpectedly, let the user know what the error is.
  • RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
    names that are sure to be invalid and which it is obvious at a glance
    are invalid." Replace dne.example.com which actually isn't guaranteed
    to not exist. (example.com is for examples, but at least one address
    does in fact exist in that TLD.)
  • test-dgram-send-cb-quelches-error works with or without a network. Move
    to parallel directory.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 19, 2019

Trott commented Nov 19, 2019

Copy link
Copy Markdown
Member Author

@joyeecheung Would you be able to confirm that this test (or at least this test with the modifications here) works for you in whatever environment you might have available that has a challenge connecting to the wider Internet? It works for me with no network, but some confirmation from you would be helpful.

This comment has been minimized.

Sign in to view
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 19, 2019

joyeecheung commented Nov 19, 2019

Copy link
Copy Markdown
Member

@Trott Works for me currently (though my ISP is not hijacking unknown hosts today).

nodejs-github-bot commented Nov 20, 2019 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26780/ ✔️

Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2019
test: improve assertion message in internet dgram test
f04f4ae 
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2019
test: use reserved .invalid TLD for invalid address in test
afa4f57 
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2019
test: move test not requiring internet from internet to parallel
03b5c46 
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: nodejs#30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott closed this Nov 21, 2019

Trott commented Nov 21, 2019

Copy link
Copy Markdown
Member Author

Landed in 9fbad51...03b5c46

Trott deleted the quelch branch November 21, 2019 18:28
MylesBorins pushed a commit that referenced this pull request Nov 21, 2019
test: improve assertion message in internet dgram test
92f766b 
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 21, 2019
test: use reserved .invalid TLD for invalid address in test
902c670 
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 21, 2019
test: move test not requiring internet from internet to parallel
cb9c64a 
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR mentioned this pull request Nov 21, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
test: improve assertion message in internet dgram test
36b6b05 
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
test: use reserved .invalid TLD for invalid address in test
7f3aec7 
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
test: move test not requiring internet from internet to parallel
aaee981 
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
test: improve assertion message in internet dgram test
d802393 
When an error occurs unexpectedly, let the user know what the error is.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
test: use reserved .invalid TLD for invalid address in test
9869aaa 
RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
test: move test not requiring internet from internet to parallel
0d26263 
test-dgram-send-cb-quelches-error works with or without a network. Move
to `parallel` directory.

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs mentioned this pull request Dec 23, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL