Commit 90aac7c
build: start comments at beginning of line
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.
PR-URL: #9375
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 4bb9d21 commit 90aac7c
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -163,8 +163,8 @@ test/addons/.buildstamp: config.gypi \ | |||
| 163 | 163 | deps/uv/include/*.h deps/v8/include/*.h \ | |
| 164 | 164 | src/node.h src/node_buffer.h src/node_object_wrap.h src/node_version.h \ | |
| 165 | 165 | test/addons/.docbuildstamp | |
| 166 | - # Cannot use $(wildcard test/addons/*/) here, it's evaluated before | ||
| 167 | - # embedded addons have been generated from the documentation. | ||
| 166 | + # Cannot use $(wildcard test/addons/*/) here, it's evaluated before | ||
| 167 | + # embedded addons have been generated from the documentation. | ||
| 168 | 168 | for dirname in test/addons/*/; do \ | |
| 169 | 169 | echo "\nRunning addons test $$PWD/$$dirname" ; \ | |
| 170 | 170 | $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \ | |
@@ -262,15 +262,15 @@ test-timers-clean: | |||
| 262 | 262 | ||
| 263 | 263 | ifneq ("","$(wildcard deps/v8/tools/run-tests.py)") | |
| 264 | 264 | test-v8: v8 | |
| 265 | - # note: performs full test unless QUICKCHECK is specified | ||
| 265 | + # note: performs full test unless QUICKCHECK is specified | ||
| 266 | 266 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ | |
| 267 | 267 | --mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) $(QUICKCHECK_ARG) \ | |
| 268 | 268 | --no-presubmit \ | |
| 269 | 269 | --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \ | |
| 270 | 270 | $(TAP_V8) | |
| 271 | 271 | ||
| 272 | 272 | test-v8-intl: v8 | |
| 273 | - # note: performs full test unless QUICKCHECK is specified | ||
| 273 | + # note: performs full test unless QUICKCHECK is specified | ||
| 274 | 274 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ | |
| 275 | 275 | --mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \ | |
| 276 | 276 | --shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \ | |
@@ -283,7 +283,7 @@ test-v8-benchmarks: v8 | |||
| 283 | 283 | $(TAP_V8_BENCHMARKS) | |
| 284 | 284 | ||
| 285 | 285 | test-v8-all: test-v8 test-v8-intl test-v8-benchmarks | |
| 286 | - # runs all v8 tests | ||
| 286 | + # runs all v8 tests | ||
| 287 | 287 | else | |
| 288 | 288 | test-v8 test-v8-intl test-v8-benchmarks test-v8-all: | |
| 289 | 289 | @echo "Testing v8 is not available through the source tarball." | |
0 commit comments