FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: start comments at beginning of line by thefourtheye · Pull Request #9375 · nodejs/node · GitHub

/ node Public

build: start comments at beginning of line - #9375

Closed
thefourtheye wants to merge 1 commit into
nodejs:masterfrom
thefourtheye:fix-comments-in-makefile
ConversationCommits (1)ChecksFiles changed
Closed

build: start comments at beginning of line#9375
thefourtheye wants to merge 1 commit into
nodejs:masterfrom
thefourtheye:fix-comments-in-makefile

Conversation

thefourtheye commented Oct 31, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.

--

cc @nodejs/build cc @nodejs/collaborators

build: start comments at beginning of line
067387f 
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.
thefourtheye added the build Issues and PRs related to build files or the CI. label Oct 31, 2016
nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 31, 2016

thefourtheye commented Oct 31, 2016

Copy link
Copy Markdown
Contributor Author

Before

...
/Applications/Xcode.app/Contents/Developer/usr/bin/make build-addons
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=1
# Cannot use test/addons/01_callbacks/ test/addons/02_object_factory/ test/addons/03_function_factory/ test/addons/04_wrapping_c_objects/ test/addons/05_factory_of_wrapped_objects/ test/addons/06_passing_wrapped_objects_around/ test/addons/07_atexit_hooks/ test/addons/async-hello-world/ test/addons/at-exit/ test/addons/buffer-free-callback/ test/addons/heap-profiler/ test/addons/hello-world-function-export/ test/addons/hello-world/ test/addons/load-long-path/ test/addons/make-callback-recurse/ test/addons/make-callback/ test/addons/node-module-version/ test/addons/null-buffer-neuter/ test/addons/openssl-binding/ test/addons/parse-encoding/ test/addons/repl-domain-abort/ test/addons/stringbytes-external-exceed-max/ test/addons/symlinked-module/ test/addons/testcfg.py test/addons/testcfg.pyc test/addons/zlib-binding/ here, it's evaluated before
# embedded addons have been generated from the documentation.
for dirname in test/addons/*/; do \
        ./node deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
            --python="/usr/local/opt/python/bin/python2.7" \
            --directory="$PWD/$dirname" \
            --nodedir="$PWD" || exit 1 ; \
    done
...

After

/Applications/Xcode.app/Contents/Developer/usr/bin/make build-addons
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=1
for dirname in test/addons/*/; do \
        ./node deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
            --python="/usr/local/opt/python/bin/python2.7" \
            --directory="$PWD/$dirname" \
            --nodedir="$PWD" || exit 1 ; \
    done

jbergstroem approved these changes Oct 31, 2016
View reviewed changes

jbergstroem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch.

silverwind approved these changes Oct 31, 2016
View reviewed changes

silverwind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, didn't know this was an issue in make

jbergstroem commented Oct 31, 2016

Copy link
Copy Markdown
Member

@silverwind: makefile is whitespace-aware. Try using ifeq() or other functions with a prefixed tab/space :)

thefourtheye commented Nov 5, 2016

Copy link
Copy Markdown
Contributor Author

Landed in f9504a5

thefourtheye deleted the fix-comments-in-makefile branch November 5, 2016 09:38
thefourtheye added a commit that referenced this pull request Nov 5, 2016
build: start comments at beginning of line
f9504a5 
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.

PR-URL: #9375

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
build: start comments at beginning of line
90aac7c 
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.

PR-URL: #9375

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas mentioned this pull request Nov 7, 2016
Merged

MylesBorins commented Nov 22, 2016

Copy link
Copy Markdown
Contributor

@thefourtheye do you want to backport this?

thefourtheye commented Nov 22, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@thealphanerd Yes. Isn't this landing cleanly?

MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
build: start comments at beginning of line
c1aee02 
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.

PR-URL: #9375

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins commented Nov 22, 2016

Copy link
Copy Markdown
Contributor

it does on v6.x but not v4.x

MylesBorins mentioned this pull request Nov 22, 2016
Merged
thefourtheye mentioned this pull request Dec 20, 2016
Closed
3 tasks

thefourtheye commented Dec 20, 2016

Copy link
Copy Markdown
Contributor Author

@thealphanerd I backported this in #10364

MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
build: start comments at beginning of line
ae2eff2 
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.

PR-URL: #9375

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
build: start comments at beginning of line
10566a8 
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.

PR-URL: #9375

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Dec 21, 2016
Merged
aliscco mentioned this pull request Jun 21, 2023
Open
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
build: start comments at beginning of line
300fa73 
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.

PR-URL: nodejs/node#9375

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
cjihrig cjihrig approved these changes
+4 more reviewers
silverwind silverwind approved these changes
jbergstroem jbergstroem approved these changes
princejwesley princejwesley approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL