V4.7.1 proposal - #10395
Merged
MylesBorins merged 181 commits intoJan 4, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Required to support the shared library builds on AIX - this sets the shared library suffix within GYP to .a instead of .so on AIX My patch: https://codereview.chromium.org/2492233002/ was landed as as part of this one which fixed some other (not required, but included for completeness of the backport) changes: Ref: https://codereview.chromium.org/2511733005/ PR-URL: #9675 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Updates to build the shared library version of node on AIX. Adds the same functionality to AIX that was added on Linux under this: Ref: #6994 PR-URL: #9675 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Add --coverage option to configure to support compiling for generation of C based coverage reports PR-URL: #9463 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #7894 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #9453 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Sam Roberts <sam@strongloop.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #9502 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #9495 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
I've noticed that a few of the code examples have an minor indentation issue with the first line, for example: https://nodejs.org/api/child_process.html#child_process_child_process This commit attempt to fix this issue by using the solution provided provided by silverwind and hiendv. Fixes: #9381 PR-URL: #9482 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Refs: nodejs/CTC#16 PR-URL: #9545 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Roman Reiss <me@silverwind.io>
fix the index order in pseudocode of modules. PR-URL: #9562 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
fix e.g., to e.g. in doc/http.md Fixes: nodejs/code-and-learn#58 PR-URL: #9564 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Fixes: nodejs/code-and-learn#58 PR-URL: #9568 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Fixes: nodejs/code-and-learn#58 PR-URL: #9563 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
It was a symbolic link to deps/v8/tools/run-valgrind.py before. We are going to make changes to it and we don't want to carry the patch forward so make a copy. PR-URL: #9520 Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
The script had a dependency on the copy of valgrind that is bundled with V8 but that only gets checked out when doing a full depot_tools checkout. Use the system-provided valgrind. PR-URL: #9520 Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Node.js does not clean up on exit so don't complain about memory leaks but do complain about invalid memory access. In the future we may want to add a cleanup-on-exit flag or put together a suppression list. PR-URL: #9520 Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #9598 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Roman Reiss <me@silverwind.io>
1. As it is, it just tries to build only the `all.html` file. If none of the other files are built already, generated page will not be good. To fix this, we process the assets and generate HTML files first. 2. After the HTML is generated, `google-chrome` is used to open the generated file in browser. This is not very portable as it might not be installed or installations might have used a different name. So, we use Python's webbrowser module to open the file. PR-URL: #9436 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
The TSC and CTC meeting minutes are more properly placed in the nodejs/tsc and nodejs/ctc repositories, respectively. PR-URL: #9503 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Ref: nodejs/Release#137 PR-URL: #9777 Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Also, remove my key, since I never did a release. PR-URL: #9862 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
* remove unnecessary backslash (`\`) escaping in regular expressions * favor `===` over `==` * multiline arrays indentation consistent with other indentation PR-URL: #9374 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
The `.` character does not need to be escaped when it appears inside a regular expression character class. This removes instances of unnecessary escapes of the `.` character. This also removes a few unnecessary escapes of the `(` and `)` characters within character classes too. PR-URL: #9449 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
This commit adds a function to test/common.js that allows additional global variables to be whitelisted in a test. PR-URL: #7826 Reviewed-By: James M Snell <jasnell@gmail.com>
The createInternalRepl() module accepts an options object as an argument. However, if one is provided, it overrides all of the default options. This commit applies the options object to the defaults, only changing the values that are explicitly set. PR-URL: #7826 Reviewed-By: James M Snell <jasnell@gmail.com>
This commit splits several large event emitter tests into smaller block scoped tests. This keeps the tests more isolated. This commit also replaces var with const, assert.equal() with assert.stictEqual(), and other small enhancements. PR-URL: #6446 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The typed array's underlying ArrayBuffer is used in `Buffer.from`. Let's respect it's .byteOffset or .byteLength (i.e. position within the parent ArrayBuffer). Fixes: #8001 PR-URL: #8002 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Let's test typed arrays which have a .byteOffset and .byteLength (i.e. typed arrays that are slices of parent typed arrays). PR-URL: #8002 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The constructor and destructor shouldn't have been placed in the -inl.h file from the beginning. Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This is how it's done everywhere else in core. Make it follow suit. Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
In this change, I've added the regex pattern to the assert.throws() in order to provide the validation argument for the call. PR-URL: #9918 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fix incorrect use of string instead of RegExp in `throws` assertions. PR-URL: #9809 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* var -> const. * Group and sort imports. * Replace use of the deprecated crypto.createCredentials. * Fix incorrect use of string instead of RegExp in `throws` assertions. * Clone array with `.slice()` and remove dependency on util. * assert.notEqual -> assert.notStrictEqual. * indexOf -> includes. PR-URL: #9807 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* var -> const. * Group and sort imports. * Correctly align function arguments. * Fix incorrect use of string instead of RegExp in `throws` assertions. * assert.equal -> assert.strictEqual. * Verify that callbacks are called with common.mustCall. PR-URL: #9810 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* More precise length assertion. * Fix incorrect use of string instead of RegExp in `throws` assertions. * Add missing RegExp to `throws` assertions. PR-URL: #9811 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
force-pushed
the
v4.7.1-proposal
branch
from
d26410d to
a7a4b94
Compare
December 27, 2016 20:11
MylesBorins
added a commit
that referenced
this pull request
Dec 27, 2016
This LTS release comes with 180 commits. This includes 117 which are test related, 34 which are doc related, 15 which are build / tool related, and 1 commit which is an update to dependencies. Notable Changes: Coming Soon PR-URL: #10395
Copy link
Copy Markdown
Contributor
Author
|
ci: https://ci.nodejs.org/job/node-test-pull-request/5602/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
One more run of KOA to ensure failure was flake: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/501/ CI one more time for smartOS: https://ci.nodejs.org/job/node-test-commit-smartos/6072/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@nodejs/platform-smartos we have the exact same failures on smartOS 15 and 16... but in separate runs. This is pretty odd https://ci.nodejs.org/job/node-test-commit-smartos/6007/nodes=smartos14-64/console Failures on 14 186 - parallel/test-debug-signal-cluster 60 ms 570 - parallel/test-net-better-error-messages-port 0 ms 579 - parallel/test-net-connect-handle-econnrefused 0 ms 582 - parallel/test-net-connect-local-error 60 ms 606 - parallel/test-net-listen-shared-ports 0 ms 617 - parallel/test-net-reconnect-error 0 ms 619 - parallel/test-net-server-bind 0 ms 630 - parallel/test-net-socket-destroy-twice 60 ms 778 - parallel/test-stream-base-no-abort 0 ms 903 - parallel/test-tls-connect-secure-context 0 ms 960 - parallel/test-tls-ticket-cluster 0 ms 1093 - sequential/test-http-regr-gh-2928 0 ms 1099 - sequential/test-pipe 1 ms 1100 - sequential/test-pump-file2tcp 0 ms 1101 - sequential/test-pump-file2tcp-noexist 0 ms 1106 - sequential/test-regress-GH-784 0 ms test failures on 15 186 - parallel/test-debug-signal-cluster 60 ms 570 - parallel/test-net-better-error-messages-port 0 ms 579 - parallel/test-net-connect-handle-econnrefused 0 ms 582 - parallel/test-net-connect-local-error 60 ms 606 - parallel/test-net-listen-shared-ports 0 ms 617 - parallel/test-net-reconnect-error 0 ms 619 - parallel/test-net-server-bind 0 ms 630 - parallel/test-net-socket-destroy-twice 60 ms 778 - parallel/test-stream-base-no-abort 0 ms 903 - parallel/test-tls-connect-secure-context 0 ms 960 - parallel/test-tls-ticket-cluster 1 ms 1093 - sequential/test-http-regr-gh-2928 0 ms 1099 - sequential/test-pipe 1 ms 1100 - sequential/test-pump-file2tcp 0 ms 1101 - sequential/test-pump-file2tcp-noexist 0 ms 1106 - sequential/test-regress-GH-784 0 ms |
Sorry, something went wrong.
Copy link
Copy Markdown
I see a lot of the following: Error: listen EADDRINUSE :::12346 in the console output of the Jenkins jobs for SmartOS. I would start looking at those. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Before you start digging too deep; perhaps check the machines for lingering processes. It is likely the case. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@jbergstroem I took a look at the machines and do not see any lingering processes at the moment. One more try: https://ci.nodejs.org/job/node-test-commit-smartos/6125/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@MylesBorins me neither! (see IRC for suggestions on how to quickly look) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
smartos is clean this time Moving forward with the release today |
Sorry, something went wrong.
Copy link
Copy Markdown
I wouldn't think it's a SmartOS specific problem. Looking at the parallel tests that call net.Server.listen, we can see that many of them bind to a common static port: ➜ v4.x git:(v4.x) git rev-parse HEAD
e92e3b5c4f697ac35d3a9b8796b5e37c4994735c
➜ v4.x git:(v4.x) grep -rHn 'listen.*common.PORT' test/parallel
test/parallel/test-cluster-basic.js:20: }).listen(common.PORT, '127.0.0.1');
test/parallel/test-cluster-bind-twice.js:70: http.createServer(common.fail).listen(common.PORT, function() {
test/parallel/test-cluster-bind-twice.js:90: server.listen(common.PORT, common.fail);
test/parallel/test-cluster-disconnect-leak.js:29:server.listen(common.PORT);
test/parallel/test-cluster-disconnect-race.js:37:server.listen(common.PORT, function() {
test/parallel/test-cluster-disconnect.js:10: }).listen(common.PORT, '127.0.0.1');
test/parallel/test-cluster-disconnect.js:14: }).listen(common.PORT + 1, '127.0.0.1');
test/parallel/test-cluster-eaddrinuse.js:15: server.listen(common.PORT, function() {
test/parallel/test-cluster-eaddrinuse.js:26: server.listen(common.PORT, common.fail);
test/parallel/test-cluster-eaddrinuse.js:33: server.listen(common.PORT, common.mustCall(function() {
test/parallel/test-cluster-ipc-throw.js:11: server.listen(common.PORT);
test/parallel/test-cluster-ipc-throw.js:18: server.listen(common.PORT);
test/parallel/test-cluster-master-error.js:11: }).listen(common.PORT, '127.0.0.1');
test/parallel/test-cluster-master-kill.js:10: http.Server().listen(common.PORT, '127.0.0.1');
test/parallel/test-cluster-message.js:42: server.listen(common.PORT, '127.0.0.1');
test/parallel/test-cluster-net-send.js:48: server.listen(common.PORT, function() {
test/parallel/test-cluster-process-disconnect.js:15: server.listen(common.PORT, common.mustCall(() => {
test/parallel/test-cluster-rr-domain-listen.js:14: http.Server(function() { }).listen(common.PORT, '127.0.0.1');
test/parallel/test-cluster-rr-ref.js:13: server.listen(common.PORT, function() {
test/parallel/test-cluster-send-deadlock.js:22: server.listen(common.PORT, function() {
test/parallel/test-cluster-send-handle-twice.js:27: server.listen(common.PORT, function() {
test/parallel/test-cluster-server-restart-none.js:26: server.listen(common.PORT, common.mustCall(() => {
test/parallel/test-cluster-server-restart-none.js:29: server.listen(common.PORT, common.mustCall(() => {
test/parallel/test-cluster-server-restart-rr.js:26: server.listen(common.PORT, common.mustCall(() => {
test/parallel/test-cluster-server-restart-rr.js:29: server.listen(common.PORT, common.mustCall(() => {
test/parallel/test-cluster-shared-handle-bind-error.js:11: net.createServer(common.fail).listen(common.PORT, function() {
test/parallel/test-cluster-shared-handle-bind-error.js:21: s.listen(common.PORT, common.fail.bind(null, 'listen should have failed'));
test/parallel/test-cluster-shared-leak.js:51:server.listen(common.PORT, function() {
test/parallel/test-cluster-worker-disconnect-on-error.js:10: server.listen(common.PORT);
test/parallel/test-cluster-worker-disconnect-on-error.js:16: server.listen(common.PORT);
test/parallel/test-cluster-worker-disconnect.js:10: }).listen(common.PORT, '127.0.0.1');
test/parallel/test-cluster-worker-exit.js:22: server.listen(common.PORT, '127.0.0.1');
test/parallel/test-cluster-worker-kill.js:18: server.listen(common.PORT, '127.0.0.1');
test/parallel/test-cluster-worker-no-exit.js:37: }).listen(common.PORT, function() {
test/parallel/test-cluster-worker-wait-server-close.js:15: }).listen(common.PORT, common.localhostIPv4);
test/parallel/test-http-status-reason-invalid-chars.js:35:}).listen(common.PORT, common.mustCall(() => {
test/parallel/test-https-connect-address-family.js:18: })).listen(common.PORT, '::1', common.mustCall(function() {
test/parallel/test-net-listen-shared-ports.js:41: server2.listen({port: common.PORT + 1, exclusive: true}, function() {
test/parallel/test-net-server-bind.js:25:server1.listen(common.PORT);
test/parallel/test-net-server-bind.js:40:server2.listen(common.PORT + 1, function() {
test/parallel/test-net-server-bind.js:52:server3.listen(common.PORT + 2, '0.0.0.0', 127, function() {
test/parallel/test-net-server-bind.js:64:server4.listen(common.PORT + 3, 127, function() {
test/parallel/test-stream-base-no-abort.js:44: .listen(common.PORT, function() {
test/parallel/test-stream-base-no-abort.js:53: net.createServer(() => {}).listen(common.PORT, function() {
test/parallel/test-tls-connect-address-family.js:17: })).listen(common.PORT, '::1', common.mustCall(function() {
test/parallel/test-tls-connect-secure-context.js:24:}).listen(common.PORT, function() {
test/parallel/test-tls-ticket-cluster.js:88:server.listen(common.PORT, function() {
➜ v4.x git:(v4.x) grep -rHn 'listen.*common.PORT' test/parallel | wc -l
47
➜ v4.x git:(v4.x)
This seems inherently flaky on all platforms. There has been a few PRs in the past to turn some of them into using a dynamically allocated port, but not all of them have been converted to use that mechanism. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@misterdjules the problem occurs if one run leaves lingering processes and the following attempts to use the same port. SmartOS has been having more lingering processes than other test systems as of late -- so this is more a symptom than a cause. |
Sorry, something went wrong.
Copy link
Copy Markdown
Absolutely, that's one of the possible causes of this problem, and I'm well aware of it. However, @MylesBorins mentioned:
and it seemed you confirmed that observation. Now, that does not mean that there were no leftover processes from previous tests runs at the time the error occurred, but it is a possibility. So, with the hypothesis of no leftover processes in mind, I was wondering what else could trigger these errors. Are tests in test/parallel actually run in parallel by the node-test-commit* Jenkins jobs? It seems like it's not the case, so that would rule out the potential problem with several tests running in parallel and binding to the same port. |
Sorry, something went wrong.
MylesBorins
force-pushed
the
v4.7.1-proposal
branch
from
a7a4b94 to
b460d9f
Compare
January 3, 2017 22:10
This LTS release comes with 180 commits. This includes 117 which are
test related, 34 which are doc related, 15 which are build / tool
related, and 1 commit which is an update to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) #9675
* repl:
- Passing options to the repl will no longer overwrite defaults
(cjihrig) #7826
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) #9685
PR-URL: #10395
MylesBorins
force-pushed
the
v4.7.1-proposal
branch
from
b460d9f to
1035318
Compare
January 3, 2017 22:37
MylesBorins
added a commit
that referenced
this pull request
Jan 4, 2017
This LTS release comes with 180 commits. This includes 117 which are
test related, 34 which are doc related, 15 which are build / tool
related, and 1 commit which is an update to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) #9675
* repl:
- Passing options to the repl will no longer overwrite defaults
(cjihrig) #7826
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) #9685
PR-URL: #10395
MylesBorins
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jan 4, 2017
imyller
added a commit
to imyller/meta-nodejs
that referenced
this pull request
Mar 2, 2017
This LTS release comes with 180 commits. This includes 117 which are
test related, 34 which are doc related, 15 which are build / tool
related, and 1 commit which is an update to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) nodejs/node#9675
* repl:
- Passing options to the repl will no longer overwrite defaults
(cjihrig) nodejs/node#7826
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) nodejs/node#9685
PR-URL: nodejs/node#10395
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller
added a commit
to imyller/meta-nodejs
that referenced
this pull request
Mar 2, 2017
This LTS release comes with 180 commits. This includes 117 which are
test related, 34 which are doc related, 15 which are build / tool
related, and 1 commit which is an update to dependencies.
Notable Changes:
* build:
- shared library support is now working for AIX builds
(Stewart Addison) nodejs/node#9675
* repl:
- Passing options to the repl will no longer overwrite defaults
(cjihrig) nodejs/node#7826
* timers:
- Re canceling a cancelled timers will no longer throw
(Jeremiah Senkpiel) nodejs/node#9685
PR-URL: nodejs/node#10395
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2016-01-03, Version 4.7.1 'Argon' (LTS), @thealphanerd
This LTS release comes with 180 commits. This includes 117 which are test related,
34 which are doc related, 15 which are build / tool related, and 1 commit which is
an update to dependencies.
Notable Changes
Coming Soon
Commits