test: refactor test-https-agent-session-reuse - #10105
Closed
dpaez wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Use const and let instead of var and assert.strictEqual() instead of assert.equal()
cjihrig
approved these changes
Dec 3, 2016
Copy link
Copy Markdown
Contributor
|
Last few CI runs have been red, but I'll give it a shot anyway: https://ci.nodejs.org/job/node-test-pull-request/5152/ |
Sorry, something went wrong.
santigimeno
reviewed
Dec 4, 2016
Comment thread
test/parallel/test-https-agent-session-reuse.js
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| if (!common.hasCrypto) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe move the const assert = require('assert'); after the if (!common.hasCrypto) {.
Sorry, something went wrong.
santigimeno
approved these changes
Dec 4, 2016
santigimeno
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with one suggestion
Sorry, something went wrong.
jasnell
approved these changes
Dec 5, 2016
addaleax
approved these changes
Dec 8, 2016
Copy link
Copy Markdown
Member
|
Landed in 83d9cd8, thanks for the contribution! |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Dec 8, 2016
Use const and let instead of var and assert.strictEqual() instead of assert.equal() PR-URL: #10105 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Dec 8, 2016
Use const and let instead of var and assert.strictEqual() instead of assert.equal() PR-URL: #10105 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Use const and let instead of var and assert.strictEqual() instead of assert.equal() PR-URL: nodejs#10105 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Use const and let instead of var and assert.strictEqual() instead of assert.equal() PR-URL: #10105 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Use const and let instead of var and assert.strictEqual() instead of assert.equal() PR-URL: #10105 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Use const and let instead of var and assert.strictEqual() instead of assert.equal() PR-URL: #10105 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Use const and let instead of var and assert.strictEqual() instead of
assert.equal()