FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor to const/let and common.mustCall · Pull Request #9934 · nodejs/node · GitHub

/ node Public

test: refactor to const/let and common.mustCall - #9934

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
ConversationCommits (1)ChecksFiles changed
Closed

test: refactor to const/let and common.mustCall#9934
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

ghost commented Dec 1, 2016

Copy link
Copy Markdown

test: refactor to const/let and common.mustCall

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

task assigned at NINA 2016 Austin code and learn
refactor var -> const/let
refactor process.on('exit') into common.mustCall

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
mscdex added the tls Issues and PRs related to the tls subsystem. label Dec 1, 2016
cjihrig reviewed Dec 4, 2016
View reviewed changes
Comment thread test/parallel/test-tls-connect-simple.js Outdated

cjihrig Dec 4, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

common.mustCall() takes an optional second argument that specifies the number of times the function should be called. You could use that here, and then completely remove the process.on('exit', ...) block.

ghost commented Dec 4, 2016

Copy link
Copy Markdown
Author

adjusted

cjihrig reviewed Dec 5, 2016
View reviewed changes
Comment thread test/parallel/test-tls-connect-simple.js Outdated

cjihrig Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think you can drop this check. It changes the behavior. The server will be closed the first time instead of the second.

test: refactor to const/let and common.mustCall
7f09a21 
refactor var -> const/let
refactor process.on('exit') into common.mustCall

ghost commented Dec 5, 2016

Copy link
Copy Markdown
Author

adjusted

cjihrig approved these changes Dec 5, 2016
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM pending CI.

jasnell approved these changes Dec 5, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM pending CI (will run the CI soon, just waiting for other jobs to finish)

jasnell commented Dec 5, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5217/

Trott commented Dec 6, 2016

Copy link
Copy Markdown
Member

Single CI failure is unrelated.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2016
test: refactor test-tls-connect-simple
d648f2b 
refactor var -> const/let
refactor process.on('exit') into common.mustCall

PR-URL: nodejs#9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Dec 6, 2016

Copy link
Copy Markdown
Member

Landed in d648f2b.
Thanks for the contribution! 🎉

Trott closed this Dec 6, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
test: refactor test-tls-connect-simple
0a07bcc 
refactor var -> const/let
refactor process.on('exit') into common.mustCall

PR-URL: #9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
test: refactor test-tls-connect-simple
2a514f2 
refactor var -> const/let
refactor process.on('exit') into common.mustCall

PR-URL: nodejs#9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
test: refactor test-tls-connect-simple
99e452b 
refactor var -> const/let
refactor process.on('exit') into common.mustCall

PR-URL: nodejs#9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
test: refactor test-tls-connect-simple
cffd51e 
refactor var -> const/let
refactor process.on('exit') into common.mustCall

PR-URL: #9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
test: refactor test-tls-connect-simple
fca534d 
refactor var -> const/let
refactor process.on('exit') into common.mustCall

PR-URL: #9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
test: refactor test-tls-connect-simple
80deda6 
refactor var -> const/let
refactor process.on('exit') into common.mustCall

PR-URL: #9934
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL