FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

var to const/let change by michael6 · Pull Request #10029 · nodejs/node · GitHub

/ node Public

var to const/let change - #10029

Closed
michael6 wants to merge 1 commit into
nodejs:masterfrom
michael6:mybranch
ConversationCommits (1)ChecksFiles changed
Closed

var to const/let change#10029
michael6 wants to merge 1 commit into
nodejs:masterfrom
michael6:mybranch

Conversation

michael6 commented Dec 1, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

change var to const/let and equal to strictEqual.

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016

imyller commented Dec 1, 2016

Copy link
Copy Markdown
Member

@michael6 May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

imyller added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. labels Dec 1, 2016
mhdawson reviewed Dec 3, 2016
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Changes look ok but commit message needs to follow guidelines as suggested. Specifically, starting with "test:' in this case.

cjihrig requested changes Dec 3, 2016
View reviewed changes
Comment thread test/parallel/test-crypto-ecb.js Outdated

cjihrig Dec 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be strictEqual

Trott reviewed Dec 4, 2016
View reviewed changes
Comment thread test/parallel/test-crypto-ecb.js Outdated

Trott Dec 4, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

const should work here

Trott reviewed Dec 4, 2016
View reviewed changes
Comment thread test/parallel/test-crypto-ecb.js Outdated

Trott Dec 4, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It would seem that const would be fine for this one too.

Trott commented Dec 4, 2016

Copy link
Copy Markdown
Member

Because of another PR with changes to this file that landed, this branch needed a rebase. I took the opportunity to fix the nits and force push directly to @michael6's branch. @cjihrig, PTAL to see if this now is approve-able. Thanks!

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2016
test: refactor test-crypto-ecb
11b3462 
* var -> const/let
* IIFE to blocks

PR-URL: nodejs#10029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Trott commented Dec 5, 2016

Copy link
Copy Markdown
Member

Landed in 11b3462.
Thanks for the contribution! 🎉

Trott closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
test: refactor test-crypto-ecb
f900753 
* var -> const/let
* IIFE to blocks

PR-URL: #10029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
test: refactor test-crypto-ecb
3aa51ec 
* var -> const/let
* IIFE to blocks

PR-URL: nodejs#10029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
test: refactor test-crypto-ecb
cef147c 
* var -> const/let
* IIFE to blocks

PR-URL: nodejs#10029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
test: refactor test-crypto-ecb
57d48ac 
* var -> const/let
* IIFE to blocks

PR-URL: #10029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
test: refactor test-crypto-ecb
b7bf180 
* var -> const/let
* IIFE to blocks

PR-URL: #10029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
test: refactor test-crypto-ecb
8c95fa4 
* var -> const/let
* IIFE to blocks

PR-URL: #10029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Dec 21, 2016
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
mhdawson mhdawson left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL