doc: minor fixes event-loop-timers-and-nexttick.md - #9126
Closed
dankoster wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Minor fixes and enhancements to event-loop-timers-and-nexttick.md Added missing "be" Added a link to REPL docs Added definition of libuv and a link
jasnell
reviewed
Oct 17, 2016
Comment thread
doc/topics/event-loop-timers-and-nexttick.md
|
|
||
| When Node.js starts, it initializes the event loop, processes the | ||
| provided input script (or drops into the REPL, which is not covered in | ||
| provided input script (or drops into the [REPL](https://nodejs.org/api/repl.html#repl_repl), which is not covered in |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nit: long line here
Sorry, something went wrong.
jasnell
approved these changes
Oct 17, 2016
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with a nit
Sorry, something went wrong.
a0viedo
approved these changes
Oct 17, 2016
a0viedo
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Maybe we should move the links to the bottom of the file like we do in other similar files. |
Sorry, something went wrong.
lpinca
approved these changes
Oct 17, 2016
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999 to
83c7a88
Compare
October 18, 2016 17:02
italoacasas
pushed a commit
that referenced
this pull request
Nov 24, 2016
Minor fixes and enhancements to event-loop-timers-and-nexttick.md Added missing "be" Added a link to REPL docs Added definition of libuv and a link PR-URL: #9126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Minor fixes and enhancements to event-loop-timers-and-nexttick.md Added missing "be" Added a link to REPL docs Added definition of libuv and a link PR-URL: #9126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Minor fixes and enhancements to event-loop-timers-and-nexttick.md Added missing "be" Added a link to REPL docs Added definition of libuv and a link PR-URL: #9126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Minor fixes and enhancements to event-loop-timers-and-nexttick.md Added missing "be" Added a link to REPL docs Added definition of libuv and a link PR-URL: #9126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Minor fixes and enhancements to event-loop-timers-and-nexttick.md Added missing "be" Added a link to REPL docs Added definition of libuv and a link PR-URL: #9126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Minor fixes and enhancements to event-loop-timers-and-nexttick.md Added missing "be" Added a link to REPL docs Added definition of libuv and a link PR-URL: #9126 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
NONE
Description of change
Minor fixes and enhancements to event-loop-timers-and-nexttick.md