first codenlearn commit - #9955
Closed
ericgonzalez wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Please see the commit message guidelines here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@ericgonzalez May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
Sorry, something went wrong.
ericgonzalez
force-pushed
the
codenlearn
branch
from
2ac7700 to
6e4e7cb
Compare
December 1, 2016 17:10
Copy link
Copy Markdown
Member
|
For the commit message, maybe: test: refactor test-buffer-indexof Change assert.equal() to assert.strictEqual(). If you amend your commit and push to your codenlearn branch, it will update this Pull Request. |
Sorry, something went wrong.
cjihrig
approved these changes
Dec 5, 2016
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, something went wrong.
jasnell
approved these changes
Dec 5, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 5, 2016
PR-URL: #9955 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in eb122b1. Thank you for the PR and for participating in the code-and-learn! |
Sorry, something went wrong.
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
PR-URL: #9955 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9955 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9955 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #9955 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9955 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9955 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 1, 2023
This was referenced Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
added strictEqual to test-buffer-indexof.js