Commit aebbc96
test: refactor large event emitter tests
This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.
PR-URL: #6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent c77ba8c commit aebbc96
1 file changed
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,13 +1,13 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | 2 | const common = require('../common'); | |
| 3 | 3 | const assert = require('assert'); | |
| 4 | - const EventEmitter = require('events'); | ||
| 4 | + const events = require('events'); | ||
| 5 | 5 | ||
| 6 | 6 | function listener1() {} | |
| 7 | 7 | function listener2() {} | |
| 8 | 8 | ||
| 9 | 9 | { | |
| 10 | - const ee = new EventEmitter(); | ||
| 10 | + const ee = new events.EventEmitter(); | ||
| 11 | 11 | ee.on('hello', listener1); | |
| 12 | 12 | ee.on('removeListener', common.mustCall((name, cb) => { | |
| 13 | 13 | assert.strictEqual(name, 'hello'); | |
@@ -18,15 +18,15 @@ function listener2() {} | |||
| 18 | 18 | } | |
| 19 | 19 | ||
| 20 | 20 | { | |
| 21 | - const ee = new EventEmitter(); | ||
| 21 | + const ee = new events.EventEmitter(); | ||
| 22 | 22 | ee.on('hello', listener1); | |
| 23 | 23 | ee.on('removeListener', common.fail); | |
| 24 | 24 | ee.removeListener('hello', listener2); | |
| 25 | 25 | assert.deepStrictEqual([listener1], ee.listeners('hello')); | |
| 26 | 26 | } | |
| 27 | 27 | ||
| 28 | 28 | { | |
| 29 | - const ee = new EventEmitter(); | ||
| 29 | + const ee = new events.EventEmitter(); | ||
| 30 | 30 | ee.on('hello', listener1); | |
| 31 | 31 | ee.on('hello', listener2); | |
| 32 | 32 | ee.once('removeListener', common.mustCall((name, cb) => { | |
@@ -46,7 +46,7 @@ function listener2() {} | |||
| 46 | 46 | } | |
| 47 | 47 | ||
| 48 | 48 | { | |
| 49 | - const ee = new EventEmitter(); | ||
| 49 | + const ee = new events.EventEmitter(); | ||
| 50 | 50 | ||
| 51 | 51 | function remove1() { | |
| 52 | 52 | common.fail('remove1 should not have been called'); | |
@@ -67,7 +67,7 @@ function listener2() {} | |||
| 67 | 67 | } | |
| 68 | 68 | ||
| 69 | 69 | { | |
| 70 | - const ee = new EventEmitter(); | ||
| 70 | + const ee = new events.EventEmitter(); | ||
| 71 | 71 | ee.on('hello', listener1); | |
| 72 | 72 | ee.on('hello', listener2); | |
| 73 | 73 | ee.once('removeListener', common.mustCall((name, cb) => { | |
@@ -87,7 +87,7 @@ function listener2() {} | |||
| 87 | 87 | } | |
| 88 | 88 | ||
| 89 | 89 | { | |
| 90 | - const ee = new EventEmitter(); | ||
| 90 | + const ee = new events.EventEmitter(); | ||
| 91 | 91 | const listener3 = common.mustCall(() => { | |
| 92 | 92 | ee.removeListener('hello', listener4); | |
| 93 | 93 | }, 2); | |
@@ -106,7 +106,7 @@ function listener2() {} | |||
| 106 | 106 | } | |
| 107 | 107 | ||
| 108 | 108 | { | |
| 109 | - const ee = new EventEmitter(); | ||
| 109 | + const ee = new events.EventEmitter(); | ||
| 110 | 110 | ||
| 111 | 111 | ee.once('hello', listener1); | |
| 112 | 112 | ee.on('removeListener', common.mustCall((eventName, listener) => { | |
0 commit comments