FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor large event emitter tests by cjihrig · Pull Request #6446 · nodejs/node · GitHub

/ node Public

test: refactor large event emitter tests - #6446

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:test
May 2, 2016
ConversationCommits (1)ChecksFiles changed
Merged

test: refactor large event emitter tests#6446
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:test

Conversation

cjihrig commented Apr 28, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This commit splits several large event emitter tests into smaller block scoped tests. This keeps the tests more isolated. This commit also replaces var with const, assert.equal() with assert.strictEqual(), and other small enhancements.

R= @Trott

cjihrig added the test Issues and PRs related to the tests. label Apr 28, 2016
santigimeno reviewed Apr 28, 2016
View reviewed changes
Comment thread test/parallel/test-event-emitter-remove-listeners.js Outdated

santigimeno Apr 28, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would it be worth to use arrow functions in the rest of the code?
The ,1 is redundant and could be removed while we're here.

santigimeno commented Apr 28, 2016

Copy link
Copy Markdown
Member

LGTM. You can ignore the comments

mscdex added the events Issues and PRs related to the events subsystem / EventEmitter. label Apr 28, 2016

jasnell commented Apr 28, 2016

Copy link
Copy Markdown
Member

LGTM

Fishrock123 commented Apr 28, 2016

Copy link
Copy Markdown
Contributor

CI, since apparently other people are perfectly comfortable signing off without it...

https://ci.nodejs.org/job/node-test-pull-request/2414/

cjihrig commented Apr 28, 2016

Copy link
Copy Markdown
Contributor Author

Flaky test-debug-port-from-cmdline.js timed out, and the OS X job didn't actually run.

jasnell commented Apr 28, 2016

Copy link
Copy Markdown
Member

New CI to see if we can get the OSX job through: https://ci.nodejs.org/job/node-test-pull-request/2417/

cjihrig commented Apr 28, 2016

Copy link
Copy Markdown
Contributor Author

Looks like CI is at least partially hanging.

addaleax commented Apr 28, 2016

Copy link
Copy Markdown
Member

https://twitter.com/thealphanerd/status/725733454625673216 ? 😄

cjihrig commented Apr 28, 2016

Copy link
Copy Markdown
Contributor Author

Heh. I guess that's that.

MylesBorins commented Apr 28, 2016

Copy link
Copy Markdown
Contributor

sorry about that 😄

jasnell commented Apr 29, 2016

Copy link
Copy Markdown
Member

CI is good.

test: refactor large event emitter tests
1ab5b4e 
This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.

PR-URL: nodejs#6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig merged commit 1ab5b4e into nodejs:master May 2, 2016
cjihrig deleted the test branch May 2, 2016 14:40
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
test: refactor large event emitter tests
7641f9a 
This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.

PR-URL: #6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 4, 2016
Closed
Merged
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
test: refactor large event emitter tests
a3d50ef 
This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.

PR-URL: nodejs#6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins commented May 18, 2016

Copy link
Copy Markdown
Contributor

this will need to be manually backported

MylesBorins commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

ping @cjihrig do you want to backport this to v4?

cjihrig commented Jun 2, 2016

Copy link
Copy Markdown
Contributor Author

@thealphanerd sure. Let me know once #6394 has landed on v4.x-staging, as this builds on it.

MylesBorins commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

@cjihrig #6394 landed! Would you be able to backport?

cjihrig added a commit to cjihrig/node that referenced this pull request Nov 23, 2016
test: refactor large event emitter tests
a6f93cd 
This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.

PR-URL: nodejs#6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig mentioned this pull request Nov 23, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
test: refactor large event emitter tests
76245b2 
This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.

PR-URL: #6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
test: refactor large event emitter tests
aebbc96 
This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.

PR-URL: #6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
test: refactor large event emitter tests
2bce891 
This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.

PR-URL: #6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
test: refactor large event emitter tests
b612003 
This commit splits several large event emitter tests into smaller
block scoped tests. This keeps the tests more isolated. This
commit also replaces var with const, assert.equal() with
assert.stictEqual(), and other small enhancements.

PR-URL: #6446
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Dec 21, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL