test: run cpplint on files in test/cctest - #9787
Merged
bnoordhuis merged 0 commit intoDec 1, 2016
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mhdawson
approved these changes
Nov 24, 2016
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
cjihrig
approved these changes
Nov 24, 2016
evanlucas
approved these changes
Nov 25, 2016
evanlucas
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
thefourtheye
approved these changes
Nov 28, 2016
bnoordhuis
force-pushed
the
cpplint-cctest
branch
from
584483d to
8264a22
Compare
December 1, 2016 13:03
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Enable cpplint for files in test/cctest. Fix up the style issues it reports. PR-URL: #9787 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Enable cpplint for files in test/cctest. Fix up the style issues it reports. PR-URL: #9787 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Enable cpplint for files in test/cctest. Fix up the style issues it reports. PR-URL: #9787 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Enable cpplint for files in test/cctest. Fix up the style issues it reports. PR-URL: #9787 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Enable cpplint for files in test/cctest. Fix up the style issues it reports. PR-URL: #9787 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable cpplint for files in test/cctest. Fix up the style issues it
reports.
cc @eugeneo, you should rebase #9630 after this.
CI: https://ci.nodejs.org/job/node-test-pull-request/4979/