build: prioritise --shared-X-Y over pkg-config - #9368
Closed
rvagg wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
jbergstroem
approved these changes
Oct 30, 2016
jbergstroem
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
sgtm and LGTM
Sorry, something went wrong.
bnoordhuis
approved these changes
Oct 30, 2016
rvagg
added a commit
that referenced
this pull request
Oct 31, 2016
PR-URL: #9368 Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
PR-URL: #9368 Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Copy link
Copy Markdown
Member
Author
|
@thealphanerd yeah, for correctness' sake, and it's low risk |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9368 Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9368 Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9368 Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9368 Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9368 Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this on OSX which is a bit more liberal with pkg-config output, you can't properly build against shared libraries when using non-standard locations for library files and headers. Switching the order of checks so --shared-X-libname, --shared-X-includes and --shared-X-libpath, if explicitly passed to ./configue, take precedence over whatever pkg-config gives you.
/R=@nodejs/build