Commit ae2eff2
build: start comments at beginning of line
As the comments are indented in Makefile, they are actually echoed
on the screen. This patch makes sure that the comments actually start
at the beginning of the line, and so not echoed and ignored.
PR-URL: #9375
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 80a7527 commit ae2eff2
1 file changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -147,8 +147,8 @@ ADDONS_BINDING_GYPS := \ | |||
| 147 | 147 | test/addons/.buildstamp: config.gypi \ | |
| 148 | 148 | deps/npm/node_modules/node-gyp/package.json \ | |
| 149 | 149 | $(ADDONS_BINDING_GYPS) test/addons/.docbuildstamp | |
| 150 | - # Cannot use $(wildcard test/addons/*/) here, it's evaluated before | ||
| 151 | - # embedded addons have been generated from the documentation. | ||
| 150 | + # Cannot use $(wildcard test/addons/*/) here, it's evaluated before | ||
| 151 | + # embedded addons have been generated from the documentation. | ||
| 152 | 152 | for dirname in test/addons/*/; do \ | |
| 153 | 153 | $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ | |
| 154 | 154 | --python="$(PYTHON)" \ | |
@@ -237,15 +237,15 @@ test-timers-clean: | |||
| 237 | 237 | $(MAKE) --directory=tools clean | |
| 238 | 238 | ||
| 239 | 239 | test-v8: v8 | |
| 240 | - # note: performs full test unless QUICKCHECK is specified | ||
| 240 | + # note: performs full test unless QUICKCHECK is specified | ||
| 241 | 241 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ | |
| 242 | 242 | --mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \ | |
| 243 | 243 | --no-presubmit \ | |
| 244 | 244 | --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \ | |
| 245 | 245 | $(TAP_V8) | |
| 246 | 246 | ||
| 247 | 247 | test-v8-intl: v8 | |
| 248 | - # note: performs full test unless QUICKCHECK is specified | ||
| 248 | + # note: performs full test unless QUICKCHECK is specified | ||
| 249 | 249 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ | |
| 250 | 250 | --mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \ | |
| 251 | 251 | --shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \ | |
@@ -258,7 +258,7 @@ test-v8-benchmarks: v8 | |||
| 258 | 258 | $(TAP_V8_BENCHMARKS) | |
| 259 | 259 | ||
| 260 | 260 | test-v8-all: test-v8 test-v8-intl test-v8-benchmarks | |
| 261 | - # runs all v8 tests | ||
| 261 | + # runs all v8 tests | ||
| 262 | 262 | ||
| 263 | 263 | apidoc_sources = $(wildcard doc/api/*.md) | |
| 264 | 264 | apidocs_html = $(apidoc_dirs) $(apiassets) $(addprefix out/,$(apidoc_sources:.md=.html)) | |
0 commit comments