tools: enable final newline in .editorconfig - #9410
Closed
silverwind wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lpinca
approved these changes
Nov 2, 2016
Copy link
Copy Markdown
Contributor
|
So we are not doing eol-last, eslint rule? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
eol-last is already in effect, I totally missed that earlier. |
Sorry, something went wrong.
thefourtheye
approved these changes
Nov 2, 2016
gibfahn
approved these changes
Nov 2, 2016
jasnell
approved these changes
Nov 3, 2016
JungMinu
approved these changes
Nov 4, 2016
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
this will require manual backporting |
Sorry, something went wrong.
silverwind
added a commit
to silverwind/node
that referenced
this pull request
Nov 22, 2016
PR-URL: nodejs#9410 Fixes: nodejs#9402 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
silverwind
added a commit
to silverwind/node
that referenced
this pull request
Nov 22, 2016
PR-URL: nodejs#9410 Fixes: nodejs#9402 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
@thealphanerd you can cherry-pick just 15b83b9. The EOL issue on benchmark/README.md seems to not be present in v6.x, v6.x-staging and v4.x, so the first commit would be a empty one :) If we're okay with empty commits, I could provide you one though. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
This enables the final newline insertion for editors supporting .editorconfig, which hopefully will eliminate noise in pull requests concerning the final newline.
The first commit is the result of the following command (requires GNU versions of find and sed):
The only offending file was benchmark/README.md. I've opted to not change test assets which would have required changes in a bunch of tests.
The second commit enables the editorconfig option. The pattern was written with the assumption that no one will manually edit files inside any node_modules directory or .min.js files.