test: Refactors variables to ES6 compatible and newer assertions - #10023
Closed
shri3k wants to merge 3 commits into
Closed
test: Refactors variables to ES6 compatible and newer assertions #10023shri3k wants to merge 3 commits into
shri3k wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- changes var to const/let
- changes assert.equal to assert.strictEqual
**Note: `process.on('exit')` wasn't able to change the handler to
`common.mustCall` because `common.mustCall` actually uses
`process.on('exit')` internally**
- changes var to const/let
- change assert.equal to assert.strictEqual
**Note: `process.on('exit')` wasn't able to change the handler to
`common.mustCall` because `common.mustCall` actually uses
`process.on('exit')` internally**
jasnell
approved these changes
Dec 5, 2016
mcollina
approved these changes
Dec 6, 2016
cjihrig
reviewed
Dec 6, 2016
Comment thread
test/parallel/test-tls-ticket.js
Outdated
| assert.strictEqual(ticketLog[i], ticketLog[i + 1]); | ||
|
|
||
| // 2nd connection should have different ticket | ||
| assert.notEqual(ticketLog[i], ticketLog[i + naturalServers.length]); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Couldn't this also use assert.notStrictEqual()?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Ah, I'll go ahead and make changes tonight. I was initially just checking for strictEqual.
Sorry, something went wrong.
cjihrig
approved these changes
Dec 6, 2016
cjihrig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, but there are probably other improvements that could be made.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
- changes `notEqual` to `notStrictEqual`
Copy link
Copy Markdown
Contributor
Author
|
@cjihrig went ahead and made the changes. Ready to be reviewed again. |
Sorry, something went wrong.
Trott
approved these changes
Dec 7, 2016
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merging now |
Sorry, something went wrong.
mcollina
pushed a commit
that referenced
this pull request
Dec 7, 2016
- changes var to const/let - changes assert.equal to assert.strictEqual - changes `notEqual` to `notStrictEqual` PR-URL: #10023 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 8, 2016
- changes var to const/let - changes assert.equal to assert.strictEqual - changes `notEqual` to `notStrictEqual` PR-URL: #10023 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
- changes var to const/let - changes assert.equal to assert.strictEqual - changes `notEqual` to `notStrictEqual` PR-URL: nodejs#10023 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
- changes var to const/let - changes assert.equal to assert.strictEqual - changes `notEqual` to `notStrictEqual` PR-URL: #10023 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
- changes var to const/let - changes assert.equal to assert.strictEqual - changes `notEqual` to `notStrictEqual` PR-URL: #10023 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
- changes var to const/let - changes assert.equal to assert.strictEqual - changes `notEqual` to `notStrictEqual` PR-URL: #10023 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Note:- even though ticket was asking to change process.on('exit') handler to common.mustCall - this was omitted as this kept breaking the test (my guess and from discussion with others was that it's because common.mustCall has process.on('exit') internally which never fires process.on('exit') in the test