Fixed the test with const and strictEqual - #9899
Closed
codeVana wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
requested changes
Dec 3, 2016
Comment thread
test/parallel/test-os-homedir-no-envvar.js
Outdated
|
|
||
| assert.ok(typeof home === 'string'); | ||
| assert.ok(home.indexOf(path.sep) !== -1); | ||
| assert.strictEqual(typeof home , 'string'); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why the indentation here? Also, no space before the comma please.
Sorry, something went wrong.
jasnell
approved these changes
Dec 5, 2016
Copy link
Copy Markdown
Member
|
Fixed linting nit and force-pushed. PTAL @cjihrig |
Sorry, something went wrong.
cjihrig
approved these changes
Dec 7, 2016
Copy link
Copy Markdown
Member
|
Failure in CI appears to be completely unrelated but still worth noting. |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Dec 7, 2016
PR-URL: #9899 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in 1b25214. Thank you for the PR and for participating in the code-and-learn! |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Dec 8, 2016
PR-URL: #9899 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9899 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #9899 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9899 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9899 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Fixed the test with const and strictEqual