test: update to const and strictEqual - #10007
Closed
ghvaldez wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Subsystem name should be all lowercase. |
Sorry, something went wrong.
Update `var` to `const` and `assert.equal` to `assert.strictEqual`
ghvaldez
force-pushed
the
update-test-parallel-priv-port
branch
from
4d6b946 to
facf714
Compare
December 1, 2016 17:31
Copy link
Copy Markdown
Contributor
Author
|
commit message updated. subsystem is now in all lowercase. |
Sorry, something went wrong.
mhdawson
approved these changes
Dec 3, 2016
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
cjihrig
approved these changes
Dec 3, 2016
Copy link
Copy Markdown
Contributor
Author
|
This is my first change...did this during code & learn NINA 2016 .... do I merge myself or will someone merge this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@ghvaldez We will do that, it just takes us a while to et everyone’s PRs reviewed and ready for merging :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
CI failure is unrelated. |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2016
Update `var` to `const` PR-URL: nodejs#10007 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Update `var` to `const` PR-URL: #10007 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Update `var` to `const` PR-URL: nodejs#10007 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Update `var` to `const` PR-URL: nodejs#10007 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Update `var` to `const` PR-URL: #10007 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Update `var` to `const` PR-URL: #10007 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Update `var` to `const` PR-URL: #10007 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Updated all var to const and updated assert.equal to
assert.strictEqual