test_runner: avoid swallowing of asynchronously thrown errors · nodejs/node@920804d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 920804d

Browse filesBrowse the repository at this point in the historyBrowse files

fossamagna

authored and

RafaelGSS

committed

test_runner: avoid swallowing of asynchronously thrown errors

Fixes: #44612 PR-URL: #45264 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 parent 4b71db1 commit 920804d
Copy full SHA for 920804d

6 files changed

+45-3Lines changed: 45 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • test.md
• lib/internal/test_runner
  • harness.js
• test
  • es-module
    • test-esm-repl-imports.js
  • fixtures/test-runner
    • extraneous_set_immediate_async.mjs
    • extraneous_set_timeout_async.mjs
  • parallel
    • test-runner-extraneous-async-activity.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/test.md‎

Copy file name to clipboardExpand all lines: doc/api/test.md

+2-2Lines changed: 2 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -272,8 +272,8 @@ top level of the file's TAP output.
272	272
273	273	The second `setImmediate()` creates an `uncaughtException` event.
274	274	`uncaughtException` and `unhandledRejection` events originating from a completed
275		- test are handled by the `test` module and reported as diagnostic warnings in
276		- the top level of the file's TAP output.
	275	+ test are marked as failed by the `test` module and reported as diagnostic
	276	+ warnings in the top level of the file's TAP output.
277	277
278	278	```js
279	279	test('a test that creates asynchronous activity', (t) => {

Collapse file

‎lib/internal/test_runner/harness.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/harness.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -46,6 +46,7 @@ function createProcessEventHandler(eventName, rootTest) {
46	46	`triggered an ${eventName} event.`;
47	47
48	48	rootTest.diagnostic(msg);
	49	+ process.exitCode = kGenericUserError;
49	50	return;
50	51	}
51	52

Collapse file

‎test/es-module/test-esm-repl-imports.js‎

Copy file name to clipboardExpand all lines: test/es-module/test-esm-repl-imports.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -9,7 +9,7 @@ const { describe, it } = require('node:test');
9	9
10	10
11	11	describe('ESM: REPL runs', { concurrency: true }, () => {
12		- it((context, done) => {
	12	+ it((done) => {
13	13	const child = spawn(execPath, [
14	14	'--interactive',
15	15	], {

Collapse file

‎test/fixtures/test-runner/extraneous_set_immediate_async.mjs‎

Copy file name to clipboard

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,5 @@
	1	+ import test from 'node:test';
	2	+
	3	+ test('extraneous async activity test', () => {
	4	+ setImmediate(() => { throw new Error(); });
	5	+ });

Collapse file

‎test/fixtures/test-runner/extraneous_set_timeout_async.mjs‎

Copy file name to clipboard

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,5 @@
	1	+ import test from 'node:test';
	2	+
	3	+ test('extraneous async activity test', () => {
	4	+ setTimeout(() => { throw new Error(); }, 100);
	5	+ });

Collapse file

‎test/parallel/test-runner-extraneous-async-activity.js‎

Copy file name to clipboard

+31Lines changed: 31 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,31 @@
	1	+ 'use strict';
	2	+ require('../common');
	3	+ const fixtures = require('../common/fixtures');
	4	+ const assert = require('assert');
	5	+ const { spawnSync } = require('child_process');
	6	+
	7	+ {
	8	+ const child = spawnSync(process.execPath, [
	9	+ '--test',
	10	+ fixtures.path('test-runner', 'extraneous_set_immediate_async.mjs'),
	11	+ ]);
	12	+ const stdout = child.stdout.toString();
	13	+ assert.match(stdout, /^# pass 0$/m);
	14	+ assert.match(stdout, /^# fail 1$/m);
	15	+ assert.match(stdout, /^# cancelled 0$/m);
	16	+ assert.strictEqual(child.status, 1);
	17	+ assert.strictEqual(child.signal, null);
	18	+ }
	19	+
	20	+ {
	21	+ const child = spawnSync(process.execPath, [
	22	+ '--test',
	23	+ fixtures.path('test-runner', 'extraneous_set_timeout_async.mjs'),
	24	+ ]);
	25	+ const stdout = child.stdout.toString();
	26	+ assert.match(stdout, /^# pass 0$/m);
	27	+ assert.match(stdout, /^# fail 1$/m);
	28	+ assert.match(stdout, /^# cancelled 0$/m);
	29	+ assert.strictEqual(child.status, 1);
	30	+ assert.strictEqual(child.signal, null);
	31	+ }

0 commit comments

Comments

0 (0)