FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: avoid swallowing of asynchronously thrown errors by fossamagna · Pull Request #45264 · nodejs/node · GitHub

/ node Public

test_runner: avoid swallowing of asynchronously thrown errors - #45264

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
fossamagna:test-runner-extraneous-async-fail
Nov 7, 2022
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: avoid swallowing of asynchronously thrown errors#45264
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
fossamagna:test-runner-extraneous-async-fail

Conversation

fossamagna commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

Fixes: #44612

nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 1, 2022
VoltrexKeyva reviewed Nov 1, 2022
View reviewed changes
Comment thread lib/internal/test_runner/harness.js Outdated
MoLow previously approved these changes Nov 1, 2022
View reviewed changes

MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but this seems to have affected test/es-module/test-esm-repl-imports.js

MoLow dismissed their stale review November 1, 2022 18:29

test/es-module/test-esm-repl-imports.js

fossamagna requested review from MoLow and VoltrexKeyva and removed request for MoLow and VoltrexKeyva November 2, 2022 06:11
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 2, 2022

nodejs-github-bot commented Nov 2, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47629/

MoLow commented Nov 2, 2022

Copy link
Copy Markdown
Member

CC @nodejs/test_runner an additional approval would be appreciated

aduh95 commented Nov 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️The commit message should start with a verb – e.g. test_runner: avoid swallowing of asynchronously thrown errors.

fossamagna changed the title test_runner: extraneous async activity make a failure test_runner: avoid swallowing of asynchronously thrown errors Nov 3, 2022

MoLow commented Nov 7, 2022

Copy link
Copy Markdown
Member

@fossamagna can you please amend the commit message?

fossamagna force-pushed the test-runner-extraneous-async-fail branch from 79cc2f1 to 5f17453 Compare November 7, 2022 06:12

fossamagna commented Nov 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@MoLow I squashed commits and amend commit message.

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2022
MoLow added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 7, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2022

This comment was marked as outdated.

Sign in to view
fossamagna deleted the test-runner-extraneous-async-fail branch November 7, 2022 13:50
This was referenced Nov 8, 2022
Open
Open
github-actions Bot mentioned this pull request Nov 10, 2022
Open
20 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
test_runner: avoid swallowing of asynchronously thrown errors
920804d 
Fixes: #44612
PR-URL: #45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS mentioned this pull request Nov 10, 2022
Merged
github-actions Bot mentioned this pull request Nov 11, 2022
Open
19 tasks
MoLow mentioned this pull request Nov 24, 2022
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
test_runner: avoid swallowing of asynchronously thrown errors
549b123 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

danielleadams commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

@fossamagna this broke when landing in v18.x-staging. Do you mind opening a backport PR for this?

fossamagna commented Dec 29, 2022

Copy link
Copy Markdown
Contributor Author

@danielleadams Yes, I will open backport PR for this.

fossamagna mentioned this pull request Dec 29, 2022
Closed
fossamagna added a commit to fossamagna/node that referenced this pull request Jan 23, 2023
test_runner: avoid swallowing of asynchronously thrown errors
024450a 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow mentioned this pull request Jan 26, 2023
Closed
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
test_runner: avoid swallowing of asynchronously thrown errors
53d8bf8 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
test_runner: avoid swallowing of asynchronously thrown errors
8eac8c3 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
fix: avoid swallowing of asynchronously thrown errors
e409b25 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
fix: avoid swallowing of asynchronously thrown errors
ce33670 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
fix: avoid swallowing of asynchronously thrown errors
cff397a 
Fixes: nodejs/node#44612
PR-URL: nodejs/node#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit 06603c44a5b0e92b1a3591ace467ce9770bf9658)
MoLow pushed a commit to MoLow/node that referenced this pull request Feb 25, 2023
test_runner: avoid swallowing of asynchronously thrown errors
9ec0a4e 
Fixes: nodejs#44612
PR-URL: nodejs#45264
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
test_runner: avoid swallowing of asynchronously thrown errors
c662025 
Fixes: #44612
PR-URL: #45264
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
test_runner: avoid swallowing of asynchronously thrown errors
5fdf374 
Fixes: #44612
PR-URL: #45264
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
MoLow MoLow approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test runner swallows uncaughtException

7 participants

Back | FazBrowse Home | New Git URL