Commit 92484d4
doc: make Web Crypto example spec compliant
subtle.sign is not supposed to support strings, and in most Web Crypto
implementations, it does not. Passing a string as the 'data' argument
only works in Node.js, and users should not rely on that oddity. The
Web Crypto spec requires the data argument to be a BufferSource, i.e.,
an ArrayBuffer or an ArrayBufferView.
PR-URL: #41556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 60e7437 commit 92484d4
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -19,9 +19,12 @@ const { subtle } = require('crypto').webcrypto; | |||
| 19 | 19 | length: 256 | |
| 20 | 20 | }, true, ['sign', 'verify']); | |
| 21 | 21 | ||
| 22 | + const enc = new TextEncoder(); | ||
| 23 | + const message = enc.encode('I love cupcakes'); | ||
| 24 | + | ||
| 22 | 25 | const digest = await subtle.sign({ | |
| 23 | 26 | name: 'HMAC' | |
| 24 | - }, key, 'I love cupcakes'); | ||
| 27 | + }, key, message); | ||
| 25 | 28 | ||
| 26 | 29 | })(); | |
| 27 | 30 | ``` | |
0 commit comments