doc: make Web Crypto example spec compliant - #41556
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
subtle.sign is not supposed to support strings, and in most Web Crypto implementations, it does not. Passing a string as the 'data' argument only works in Node.js, and users should not rely on that oddity. The Web Crypto spec requires the data argument to be a BufferSource, i.e., an ArrayBuffer or an ArrayBufferView.
jasnell
approved these changes
Jan 16, 2022
aduh95
approved these changes
Jan 16, 2022
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
subtle.sign spec: https://w3c.github.io/webcrypto/#SubtleCrypto-method-sign
BufferSource spec: https://webidl.spec.whatwg.org/#BufferSource
Sorry, something went wrong.
lpinca
approved these changes
Jan 16, 2022
benjamingr
approved these changes
Jan 16, 2022
panva
approved these changes
Jan 17, 2022
cjihrig
approved these changes
Jan 17, 2022
Copy link
Copy Markdown
Member
Author
|
Landed in eceb2e7, thanks for reviewing. |
Sorry, something went wrong.
tniessen
added a commit
that referenced
this pull request
Jan 18, 2022
subtle.sign is not supposed to support strings, and in most Web Crypto implementations, it does not. Passing a string as the 'data' argument only works in Node.js, and users should not rely on that oddity. The Web Crypto spec requires the data argument to be a BufferSource, i.e., an ArrayBuffer or an ArrayBufferView. PR-URL: #41556 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
subtle.sign is not supposed to support strings, and in most Web Crypto implementations, it does not. Passing a string as the 'data' argument only works in Node.js, and users should not rely on that oddity. The Web Crypto spec requires the data argument to be a BufferSource, i.e., an ArrayBuffer or an ArrayBufferView. PR-URL: #41556 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 26, 2022
subtle.sign is not supposed to support strings, and in most Web Crypto implementations, it does not. Passing a string as the 'data' argument only works in Node.js, and users should not rely on that oddity. The Web Crypto spec requires the data argument to be a BufferSource, i.e., an ArrayBuffer or an ArrayBufferView. PR-URL: #41556 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subtle.sign is not supposed to support strings, and in most Web Crypto implementations, it does not. Passing a string as the data argument only works in Node.js, and users should not rely on that oddity. The Web Crypto spec requires the data argument to be a BufferSource, i.e., an ArrayBuffer or an ArrayBufferView.